Skip to content

Convert content below hours grid to a widget area#354

Merged
matt-bernhardt merged 1 commit intomainfrom
uxws-1367-below-hours-content
May 5, 2022
Merged

Convert content below hours grid to a widget area#354
matt-bernhardt merged 1 commit intomainfrom
uxws-1367-below-hours-content

Conversation

@matt-bernhardt
Copy link
Copy Markdown
Member

@matt-bernhardt matt-bernhardt commented May 3, 2022

Why are these changes being introduced:

  • As the Libraries have re-opened, there have been a number of changes
    to the currently-static-HTML content below the hours grid. In order to
    allow us to change this content more responsively as the organization
    evolves, this converts that static content into a widget area so that
    changes don't require code updates.

Relevant ticket(s):

How does this address that need:

  • This takes out the static content from page-hours-json.php and
    replaces it with a new sidebar area. As part of the deploy of this, I
    will create and populate a widget with the static content.

Document any side effects to this change:

  • The actual markup around this content will change, but not in a way
    that will be visible to the user or a search engine.

How can a reviewer manually see the effects of these changes?

As I write this, the branch is currently not deployed anywhere - so if you have a local network you can look at it there. If not, then I'll be deploying this to staging once #353 is through code review.

Screenshots (if appropriate)

Here's the current production hours page...
Screen Shot 2022-05-03 at 4 41 26 PM

Converting that "Locations without hours" block to a widget area will momentarily cause it to disappear (this is from staging, after deploying the branch and before creating the new widget)
Screen Shot 2022-05-03 at 4 28 05 PM

After the widget has been defined (taking care to remove the bit about the Physics reading room that motivated this entire ticket), the page looks like this:
Screen Shot 2022-05-04 at 9 57 18 AM

Todo:

  • Documentation
  • Stakeholder approval

Requires new or updated plugins, themes, or libraries?

NO

Requires change to deploy process?

NO

@matt-bernhardt matt-bernhardt force-pushed the uxws-1367-below-hours-content branch from 96f2e6a to ae8359d Compare May 3, 2022 20:45
** Why are these changes being introduced:

* As the Libraries have re-opened, there have been a number of changes
  to the currently-static-HTML content below the hours grid. In order to
  allow us to change this content more responsively as the organization
  evolves, this converts that static content into a widget area so that
  changes don't require code updates.

** Relevant ticket(s):

* https://mitlibraries.atlassian.net/browse/uxws-1367

** How does this address that need:

* This takes out the static content from page-hours-json.php and
  replaces it with a new sidebar area. As part of the deploy of this, I
  will create and populate a widget with the static content.

** Document any side effects to this change:

* The actual markup around this content will change, but not in a way
  that will be visible to the user or a search engine.
@matt-bernhardt matt-bernhardt force-pushed the uxws-1367-below-hours-content branch from ae8359d to a212495 Compare May 4, 2022 13:53
@matt-bernhardt matt-bernhardt requested review from JPrevost and jazairi May 4, 2022 16:55
@jazairi jazairi self-assigned this May 4, 2022
Copy link
Copy Markdown
Contributor

@jazairi jazairi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't confirmed this because I found myself going down an unintentional rabbit hole with my local WP environment, but the code looks good and the premise makes sense. Thanks for including such excellent detail in the PR. :shipit:

@matt-bernhardt matt-bernhardt merged commit eadc063 into main May 5, 2022
@matt-bernhardt matt-bernhardt deleted the uxws-1367-below-hours-content branch May 5, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants