Updates to frontpage styling and content#355
Merged
matt-bernhardt merged 2 commits intomainfrom May 12, 2022
Merged
Conversation
matt-bernhardt
force-pushed
the
uxws-1366-libguide-links
branch
from
c23cf15 to
11ee0bd
Compare
** Why are these changes being introduced: * The frontpage loads a random collection of libguides to show to the user. While those guides have been stable over years, two of them recently changed their URLs. ** Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/uxws-1366 ** How does this address that need: * This updates the curated set of guides that this theme stores with the current URLs. * I considered some deeper changes to this feature, including: * Widgetizing the area and loading one widget at random * Loading guide information from the libguides API * Creating a custom post type for guides, similar to how we handle expert profiles, and loading those at random using similar JS Each of those would involve more engineering work than I think is warranted at the moment (given that this is the first change in several years). However, if more changes start coming then each of these could be more viable than a static HTML document in the theme. ** Document any side effects to this change: * None, but we are choosing to continue using a hard-to-update feature of the theme.
matt-bernhardt
force-pushed
the
uxws-1366-libguide-links
branch
from
11ee0bd to
eb20e80
Compare
matt-bernhardt
changed the title
JPrevost
approved these changes
May 12, 2022
Member
JPrevost
left a comment
JPrevost
left a comment
There was a problem hiding this comment.
While in some ways hard to update, it's also possible this would be a good file to encourage UX to edit themselves as it's HTML and not PHP.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes being introduced:
user. While those guides have been stable over years, two of them
recently changed their URLs.
Relevant ticket(s):
How does this address that need:
current URLs.
expert profiles, and loading those at random using similar JS
Each of those would involve more engineering work than I think is
warranted at the moment (given that this is the first change in
several years). However, if more changes start coming then each of
these could be more viable than a static HTML document in the theme.
Document any side effects to this change:
of the theme.
How can a reviewer manually see the effects of these changes?
Todo:
Requires new or updated plugins, themes, or libraries?
NO
Requires change to deploy process?
NO