DO NOT MERGE - CI and Pantheon updates for parent theme#357
Open
matt-bernhardt wants to merge 19 commits intoMITLibraries:mainfrom
Open
DO NOT MERGE - CI and Pantheon updates for parent theme#357matt-bernhardt wants to merge 19 commits intoMITLibraries:mainfrom
matt-bernhardt wants to merge 19 commits intoMITLibraries:mainfrom
Conversation
This applies to functions.php and lib/news.php
This is applied to: - hours location images - lightbox library - guide loading on the home page - map icons within mapJS - loading fonts.js for productionJS and homeJS This also removes an apaprently-unused file - js/make.googlemap.js
It wasn't possible to use the i18n approach here, so instead we are just using relative paths back to the images and libs directories.
- Update theme name and screenshot - Adds sidebar styles found in Customizer
Make theme directory-agnostic
Finishes fork groundwork, adds Composer support
Following the GUI provided by GitHub for enabling Actions...
Establish build process using GitHub Actions
Update build workflows based on lessons learned in other projects
** Why are these changes being introduced: * We need to be able to load system alerts from external sources, now that we are going to be deploying many WordPress applications. The status quo is to load from a hard-coded URL on the same domain (from the parent site). That needs to be more flexible. ** Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/engx-147 ** How does this address that need: * This defines a theme setting for the alert URL, which can be edited by site builders. That value is made available to site javascript using the ALERT_URL constant, rendered by wp_add_inline_script(). * It also defines a dashboard settings form for modifying that setting (which is in a separate class, although I'm not sure that is the best choice). ** Document any side effects to this change: * There are now more files in the lib/ folder, which may not be ideal. The preferrable theme organization is unclear to me, so I've gone with a folder that already exists.
Add support for loading alerts from remote systems
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
| 'p' => array(), | ||
| ); | ||
|
|
||
| $template = '<input type="text" name="%s" value="%s" id="%s" size="60"><p>This should be the fully-qualified URL for the WordPress application which hosts Alert content. The original value was https://libraries.mit.edu/wp-json/wp/v2/posts/</p>'; |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the creation of the prototype WordPress site on Pantheon in January 2022, I forked our parent and child themes into projects I could manipulate more easily. Now that we are anticipating putting this work into production, I wanted to see how ugly the merge would be to capitalize on that effort in the current codebase - or if it would be necessary to just carry forward with the forks as new themes.
This PR is how I'm checking on that question.
Status
Use labels (
review needed,in progress, orpaused) to declare statusWhat does this PR do?
A few sentences describing the overall goals of the pull request's commits.
Why are we making these changes? Is there more work to be done to fully
achieve these goals?
Helpful background context (if appropriate)
How can a reviewer manually see the effects of these changes?
What are the relevant tickets?
Screenshots (if appropriate)
Todo:
Requires new or updated plugins, themes, or libraries?
YES | NO
Requires change to deploy process?
YES | NO