Merged
Conversation
matt-bernhardt
force-pushed
the
uxws-1378-nav-updates
branch
from
1e94f90 to
c8f363a
Compare
** Why are these changes being introduced: * There are a number of links in our header and footer that need to change. ** Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/uxws-1378 ** How does this address that need: * This makes all the changes in the header and footer which are called for in the linked Jira ticket (UXWS-1378) ** Document any side effects to this change: * None
** Why are these changes being introduced: * ANDI has flagged a portion of our branding for a while with a "Misuses of Alt attribute" message, because we've added an alt attribute to an anchor tag. This is incorrect, but was taken because the SVG element inside the anchor can't make use of an alt attribtue. ** Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/engx-67 ** How does this address that need: * This adopts the preferred approach in this sort of use case, using a title tag inside the inlined SVG: https://css-tricks.com/accessible-svgs/#aa-2-inline-svg ** Document any side effects to this change: * None
matt-bernhardt
force-pushed
the
uxws-1378-nav-updates
branch
from
c8f363a to
cf89e62
Compare
jazairi
approved these changes
Jun 7, 2022
Contributor
jazairi
left a comment
jazairi
left a comment
There was a problem hiding this comment.
Thanks for taking on that a11y issue! 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This combines the work of two tickets, both of which ask for changes to our theme navigation.
The first change makes a series of updates to the header and footer which were requested by UX in their ticket.
The second change resolves a longstanding issue that was flagged by one of our a11y checks, wherein we'd used an alt attribute on an anchor tag.
How can a reviewer manually see the effects of these changes?
This will be visible on the staging server.
What are the relevant tickets?
Todo:
Requires new or updated plugins, themes, or libraries?
NO
Requires change to deploy process?
NO