Updates NPM packages, removes unused ones#360
Merged
matt-bernhardt merged 1 commit intomainfrom Jun 23, 2022
Merged
Conversation
** Why are these changes being introduced: * It has been a while since we did maintenance on our NPM / Grunt setup. As a result, there are a few outdated packages, and some that we no longer use as part of our build step. ** Relevant ticket(s): * n/a - maintenance week task ** How does this address that need: * This removes a few npm packages that were used in the past for theme builds, but are no longer relevant: * connect * imagemin * jshint * watch * This also runs `npm update` to get our deeper dependencies as close to current as we can make them. * Bumps theme version to 1.13.1 There are a few steps we could take to go further down this path, but are not part of this PR yet: * The PHPCS package can probably be removed soon, but that should probably be part of the CI rebuild / adoption of GitHub Actions. * The output of `npm outdated` shows a number of base packages have newer versions available, but those may introduce breaking changes so the work is a bit more hands-on than our typical maintenance-week tasks. ** Document any side effects to this change: * Updates /style.css to use "unbuilt" as its version number, as a clearer warning that a step was skipped in the deploy process. In the future only the version number in css/style.css should need to be updated.
matt-bernhardt
force-pushed
the
audit-dep-updates
branch
from
761d1e6 to
e8957e1
Compare
Member
Author
|
As usual for our maintenance work, I'm merging this without code review. I have, however, deployed the update to staging and run through the list of reference URLs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes being introduced:
As a result, there are a few outdated packages, and some that we no
longer use as part of our build step.
Relevant ticket(s):
How does this address that need:
builds, but are no longer relevant:
npm updateto get our deeper dependencies as close tocurrent as we can make them.
There are a few steps we could take to go further down this path, but
are not part of this PR yet:
probably be part of the CI rebuild / adoption of GitHub Actions.
npm outdatedshows a number of base packages havenewer versions available, but those may introduce breaking changes so
the work is a bit more hands-on than our typical maintenance-week
tasks.
Document any side effects to this change:
Todo:
Requires new or updated plugins, themes, or libraries?
YES
Requires change to deploy process?
NO