Merged
Conversation
Why these changes are being introduced:
This commit addresses the following issue:
The stage-build.yml is still configured to build and push an ECR image when a
PR is opened; it should push an ECR image when there is a push to main, as
would happen after the PR is approved and merged. This way, if more commits
are added during the PR review process, they will end up in the final ECR
image deployed to Stage. Currently stage-build is triggered in the same way
as dev-build meaning that any extra commits would not make it to the Stage
image.
How this addresses that need:
Modifies the build gh workflow to build the container on merge rather than
commit.
Side effects of this change:
None
Changes to be committed:
modified: .github/workflows/stage-build.yml
Contributor
Author
|
Coveralls is currently down. So, the failure is with the service not this code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose and background context
The stage-build.yml is still configured to build and push an ECR image when a PR is opened; it should push an ECR image when there is a push to main, as would happen after the PR is approved and merged. This way, if more commits are added during the PR review process, they will end up in the final ECR image deployed to Stage. Currently stage-build is triggered in the same way as dev-build meaning that any extra commits would not make it to the Stage image.
How can a reviewer manually see the effects of these changes?
Modifies the build gh workflow to build the prod container on PR merge rather than commit.
Includes new or updated dependencies?
NO
Changes expectations for external applications?
NO
What are the relevant tickets?
https://mitlibraries.atlassian.net/browse/IN-1175
Developer
Code Reviewer(s)