Merged
Conversation
Why these changes are being made: With the updates to the infrastructure and the use of peristent storage for a few of the paths in the `/var/www/html`, we needed to change how we managed the container. How these changes are implemented: * Update CODEOWNERS to force review by Dhruti when the Dockerfile is modified * Minor adjustments to the config.ini.php file related to report archiving. * Update the backup script to use tar (this is just copying the techinque I found in the entrypoint script) * Minor updates to some documentation Related Jira Tickets: * https://mitlibraries.atlassian.net/browse/IN-1301
tim-rix
reviewed
Jun 5, 2025
tim-rix
approved these changes
Jun 5, 2025
Contributor
tim-rix
left a comment
tim-rix
left a comment
There was a problem hiding this comment.
Everything looks OK to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Helpful background context
With the updates to the infrastructure and the use of persistent storage for a few of the paths in the
/var/www/html, we needed to change how we manage the container. See PR#28 in the infrastructure repository. These are the infrastructure changes that must be deployed before this updated container should be deployed.How can a reviewer manually see the effects of these changes?
Includes new or updated dependencies?
YES: But not in the traditional sense! With this update, the running service container (and the report archive task) now explicitly require that the EFS filesystem is available and that certain folders and files are accessible.
What are the relevant tickets?
Developer
Code Reviewer
(not just this pull request message)