Merged
Conversation
Why these changes are being introduced:
This commit add new standardized workflows to this repository. It expands the
files and documentaion and brings them up to our new standards. This should
significantly reduce the amount of work it takes for us to deploy new apps
off of this template and reduce errors and missing code/docs while doing so.
Finally, this commit updates the version of terraform and pre-commit action
dependency programs.
How this addresses that need:
- Add pre-commit hooks, files, and code
- Update terraform version to v1.10
- Update all workflow app versions
- SECURITY: restrict GH workflows to readonly
- Add CODEOWNERS file
- Add set/delete initial SSM param scripts
- README.md documentation updates
- Add placeholder .terraform.lock.hcl
Side effects of this change:
None
Changes to be committed:
new file: .github/CODEOWNERS
modified: .github/workflows/tf-shared-workflows.yml
new file: .pre-commit-config.yaml
new file: .terraform-docs.yaml
new file: .terraform.lock.hcl
modified: README.md
modified: files/README.md
new file: files/delete_initial_ssm_param.sh
new file: files/set_initial_ssm_param.sh
modified: versions.tf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Developer Checklist
What does this PR do?
This PR add new standardized workflows to this repository. It expands the files and documentation and brings them up to our new standards. This should significantly reduce the amount of work it takes for us to deploy new apps off of this template and reduce errors and missing code/docs while doing so. Finally, this PR updates the version of terraform and pre-commit action dependency programs.
How this addresses that need:
Side effects of this change:
None
Changes to be committed:
new file: .github/CODEOWNERS
modified: .github/workflows/tf-shared-workflows.yml
new file: .pre-commit-config.yaml
new file: .terraform-docs.yaml
new file: .terraform.lock.hcl
modified: README.md
modified: files/README.md
new file: files/delete_initial_ssm_param.sh
new file: files/set_initial_ssm_param.sh
modified: versions.tf
What are the relevant tickets?
This is maintenance work. There are no tickets directly associated with this work.
Requires Database Migrations?
NO
Includes new or updated dependencies?
YES (Terraform version upgrade; general workflow version upgrades)