Merged
Conversation
* Add PR template * Add shared CI workflow * Add .gitignore * Add Dockerfile * Add ping and ppod lambda functions * Add Makefile * Add Pipfile and requirements.txt for dependencies * Add README.md * Add setup.cfg to manage linting * Add tests for lambda functions * https://mitlibraries.atlassian.net/browse/ENSY-68
* Update Dockerfile * Update Makefile * Add unit test
hakbailey
suggested changes
May 17, 2022
Contributor
hakbailey
left a comment
hakbailey
left a comment
There was a problem hiding this comment.
I think we only expect this repo to have one lambda function, right? So we can probably remove ping.py (which is mostly useful as an example of how to run different lambda functions from the same repo) and just put ppod.py and its test file in the root directory.
Contributor
Author
|
I had assumed the |
ehanson8
commented
May 18, 2022
|
|
||
| bandit: | ||
| pipenv run bandit -r lambdas | ||
| pipenv run bandit -r ppod.py |
Contributor
Author
There was a problem hiding this comment.
I'm using a .bandit file in my next PR to skip the test files since this approach will get annoying fast as more files are added
Contributor
There was a problem hiding this comment.
It's possible we may not need to add more files, and can just keep everything in the ppod.py module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helpful background context
Initial repo setup for the
ppodlambdaWhat are the relevant tickets?
https://mitlibraries.atlassian.net/browse/ENSY-68
Developer
Code Reviewer
(not just this pull request message)
Includes new or updated dependencies?
YES