Conversation
Why these changes are being introduced: * ppod needs to post MARC records to POD streams using an access token How this addresses that need: * Add mocked_pod and pod_response fixture and update test_env fixture with new variables * Add requests module and related dependencies to Pipfile * Add post_files_to_pod function * Add unit tests for new function * Update README.md to include new envs Side effects of this change: * New env required to run the code Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/ENSY-71
hakbailey
suggested changes
May 31, 2022
Contributor
hakbailey
left a comment
hakbailey
left a comment
There was a problem hiding this comment.
See inline comments, the code naming/clarity suggestions are totally optional but the stream name source and the bad url test need to be updated. Lmk if you have questions!
* Rename fixtures for consistency and accuracy * Add marcxml and mocked_ssm fixtures * Update mocked_pod fixture * Remove pod response fixture due to lack of use response text in the app * Rename function to post_file_to_pod * Correct file type in post_file_to_pod * Update log message after posting a file * Shift types-requests to dev in Pipfile * Update tests with new fixtures
hakbailey
reviewed
Jun 1, 2022
Contributor
hakbailey
left a comment
hakbailey
left a comment
There was a problem hiding this comment.
Just a couple more suggestions for clarity and test efficiency. Maybe go ahead and update the README env variables and instructions while you're at it? Then we'll be totally done after this PR!
* Change fixture parameters for greater efficiency * Renamed ENV for clarity * Update SSM call to remove unnecessary decryption * Update requirements.txt * Update README.md with dev1 testing instructions * Remove unnecessary fixture calls
hakbailey
reviewed
Jun 1, 2022
* Add export bucket note
hakbailey
approved these changes
Jun 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helpful background context
This PR completes the core functionality of the
ppodapp so full end-to-end testing is now possible.How can a reviewer manually see the effects of these changes?
Local testing functionality will be added as a part of ENSY-85
What are the relevant tickets?
Developer
Code Reviewer
(not just this pull request message)
Includes new or updated dependencies?
YES