Conversation
# Subject Applies a universal github workflow and standard makefile commands to the app. # Why these changes are being introduced: This commit is part of a larger refactor of how we handle ECR repositories and generating makefile and github workflows. The work here will likely be removed when stage and prod are deployed, so this is a temporary change, but serves as a proof of concept/stopgap until stage is ready. The changes here represent a direct copy/paste from the infrastructure repository. # How this addresses that need: Add the dev-build workflow Update the makefile with our new standard format # Side effects of this change: A test of this workflow will happen when I submit the PR for this. # Relevant ticket(s): NA
ehanson8
approved these changes
Jun 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subject
Applies a universal github workflow and standard makefile commands to the app.
Why these changes are being introduced:
This commit is part of a larger refactor of how we handle ECR repositories and generating makefile and github workflows.
The work here will likely be removed when stage and prod are deployed, so this is a temporary change, but serves as a proof of concept/stopgap until stage is ready.
The changes here represent a direct copy/paste from the infrastructure repository.
How this addresses that need:
Add the dev-build workflow
Update the makefile with our new standard format
Side effects of this change:
A test of this workflow will happen when I submit the PR for this.
Relevant ticket(s):
NA