Skip to content

Update error messages#7

Merged
hakbailey merged 1 commit intomainfrom
update-error-messages
Jun 8, 2022
Merged

Update error messages#7
hakbailey merged 1 commit intomainfrom
update-error-messages

Conversation

@hakbailey
Copy link
Contributor

@hakbailey hakbailey commented Jun 8, 2022

What does this PR do?

Makes minor updates to a couple of the error messages for clarity. Also updates .gitignore to ignore vscode workspace files.

How can a reviewer manually see the effects of these changes?

Run the lambda in Dev1 with input {"filename-prefix": "wrong"} to see the prefix error. Probably not necessary to verify the tarfile error.

Developer

  • All new ENV is documented in README
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

Includes new or updated dependencies?

NO

Why these changes are being introduced:
A couple of the error messages are slightly confusing in the
notification emails because we can't easily filter or format the text
before sending.

How this addresses that need:
* Makes minor updates to a couple error messages for clarity.
* Also updates .gitignore to ignore vscode workspace files.
@hakbailey hakbailey requested a review from ehanson8 June 8, 2022 16:32
Copy link
Contributor

@ehanson8 ehanson8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes!

@hakbailey hakbailey merged commit 9957f62 into main Jun 8, 2022
@hakbailey hakbailey deleted the update-error-messages branch June 8, 2022 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants