Conversation
Why these changes are being introduced: We were encountering some errors after SQLAlchemy automatically updated to 2.0.45 that mentioned "pg_catalog" and "pg_collation". We use duckdb_engine, a SQLAlchemy engine, to interact with our DuckDB connection. It looks as though SQLAlchemy 2.0.45, for reasons unknown at this time, break that engine, at least the table reflection which we use on TIMDEXDataset inititialization. How this addresses that need: * Pins SQLAlchemy to 2.0.44 until we learn more or a new version is released. Side effects of this change: * SQLAlchemy will be pinned until touched again. Relevant ticket(s): * None
jonavellecuerdo
approved these changes
Dec 11, 2025
Pull Request Test Coverage Report for Build 20138980492Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose and background context
Why these changes are being introduced:
We were encountering some errors after SQLAlchemy automatically updated to 2.0.45 that mentioned "pg_catalog" and "pg_collation". We use
duckdb_engine, a SQLAlchemy engine, to interact with our DuckDB connection. It looks as though SQLAlchemy 2.0.45 -- for reasons unknown at this time -- break that engine, at least the table reflection which we use onTIMDEXDatasetinititialization.How this addresses that need:
Side effects of this change:
How can a reviewer manually see the effects of these changes?
Explain how to see the proposed changes in the application if possible.
Delete this section if it isn't applicable to the PR.
Includes new or updated dependencies?
YES
Changes expectations for external applications?
NO
What are the relevant tickets?
Code review