-
Notifications
You must be signed in to change notification settings - Fork 0
Update CI to use shared workflows for testing and linting #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI to use shared workflows for testing and linting #33
Conversation
|
Opening the PR did not trigger the CI workflow because e9a5ec2 changed a file within the |
|
Pushing a commit triggered the CI workflow because the temporarily pushed commit 17e9328 changed a file outside the The Dev Deploy workflow also ran because a PR was opened for a branch with a commit that included a change outside the |
|
I will mark this PR as a draft until I can update the shared workflow to use the versions from the |
ghukill
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for all the legwork here.
|
Heads up: Rebasing to clean up commits so the commits linked in the comments and PR description will be inaccessible (think they'll still show up in |
33ae469 to
68bdbf9
Compare
Purpose and background context
IMPORTANT: This PR was started as a "Ready for Review" PR then converted to a "Draft PR" at the end of testing. It was converted to a draft PR as it depends on an open PR for the
.githubrepo that still needs review.How can a reviewer manually see the effects of these changes?
This PR itself demonstrates that the GitHub CI workflow automations are properly configured. As a reminder, the CI workflow should execute when:
The sequence of steps I performed were as follows:
.github/directory. You can confirm this by:Actionstab and filtering to 'push' events: You won't see any for commit e9a5ec2..github/directory.Actionstab and filtering to 'pull_request' events: The push to the head branch is considered a 'synchronized' activity type..github/directory. This suggests that GitHub actions looks at the total or net changes when determining whether the workflow should execute. 🤔Based on the outcomes above, I think the proposed changes to
.github/workflows/ci.ymlfor this repo are sufficient and should be applied to our Python template repos!Includes new or updated dependencies?
NO
Changes expectations for external applications?
NO
What are the relevant tickets?
Code review