Skip to content

Conversation

@jonavellecuerdo
Copy link
Contributor

@jonavellecuerdo jonavellecuerdo commented Jan 6, 2026

Purpose and background context

IMPORTANT: This PR was started as a "Ready for Review" PR then converted to a "Draft PR" at the end of testing. It was converted to a draft PR as it depends on an open PR for the .github repo that still needs review.

How can a reviewer manually see the effects of these changes?

This PR itself demonstrates that the GitHub CI workflow automations are properly configured. As a reminder, the CI workflow should execute when:

  • the PR is opened
  • the PR is reopened
  • a push is made to the head branch of the PR

The sequence of steps I performed were as follows:

  1. Create a new branch (the HEAD branch of this PR)
  2. Push commit e9a5ec2
  3. Created the PR
  4. 🔔 IMPORTANT: As noted in Update CI to use shared workflows for testing and linting #33 (comment), the CI was not executed because the commit did not change any files outside of the .github/ directory. You can confirm this by:
  5. Push commit 17e9328 with a temporary change to which a file outside of .github/ directory.
  6. 🔔 IMPORTANT: As noted in Update CI to use shared workflows for testing and linting #33 (comment), the CI was executed. You can confirm this by:
  7. Push commit 33ae469 to undo the change from the previous commit.
  8. 🔔 IMPORTANT: As noted in Update CI to use shared workflows for testing and linting #33 (comment), the CI was not executed, even though it was a change to a file outside of the .github/ directory. This suggests that GitHub actions looks at the total or net changes when determining whether the workflow should execute. 🤔
  9. Then, the PR was converted to a draft.

Based on the outcomes above, I think the proposed changes to .github/workflows/ci.yml for this repo are sufficient and should be applied to our Python template repos!

Includes new or updated dependencies?

NO

Changes expectations for external applications?

NO

What are the relevant tickets?

Code review

  • Code review best practices are documented here and you are encouraged to have a constructive dialogue with your reviewers about their preferences and expectations.

@jonavellecuerdo
Copy link
Contributor Author

jonavellecuerdo commented Jan 6, 2026

Opening the PR did not trigger the CI workflow because e9a5ec2 changed a file within the .github/... directory.

@jonavellecuerdo
Copy link
Contributor Author

jonavellecuerdo commented Jan 6, 2026

Pushing a commit triggered the CI workflow because the temporarily pushed commit 17e9328 changed a file outside the .github/... directory.

The Dev Deploy workflow also ran because a PR was opened for a branch with a commit that included a change outside the .github/... directory and the base branch is main.

@jonavellecuerdo
Copy link
Contributor Author

jonavellecuerdo commented Jan 6, 2026

Interestingly, pushing the commit 33ae469 that undoes the change from 17e9328 did not trigger the CI. Perhaps this is because the net change GItHub detects is that only the .github/workflows/ci.yml changed (which is actually impressive 😮 🤓)

@jonavellecuerdo
Copy link
Contributor Author

I will mark this PR as a draft until I can update the shared workflow to use the versions from the main branch!

@jonavellecuerdo jonavellecuerdo marked this pull request as draft January 6, 2026 20:44
@jonavellecuerdo jonavellecuerdo marked this pull request as ready for review January 6, 2026 22:14
@jonavellecuerdo jonavellecuerdo marked this pull request as draft January 6, 2026 22:14
@jonavellecuerdo jonavellecuerdo requested a review from a team January 7, 2026 14:36
@jonavellecuerdo jonavellecuerdo marked this pull request as ready for review January 7, 2026 14:36
Copy link
Collaborator

@ghukill ghukill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for all the legwork here.

@jonavellecuerdo
Copy link
Contributor Author

Heads up: Rebasing to clean up commits so the commits linked in the comments and PR description will be inaccessible (think they'll still show up in git reflog).

@jonavellecuerdo jonavellecuerdo force-pushed the IN-1536-use-shared-github-workflows-for-uv branch from 33ae469 to 68bdbf9 Compare January 7, 2026 14:45
@jonavellecuerdo jonavellecuerdo merged commit 5b8e972 into main Jan 7, 2026
@jonavellecuerdo jonavellecuerdo deleted the IN-1536-use-shared-github-workflows-for-uv branch January 7, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants