verification exp.: simplify secondary tests usage of "prepare_run"#975
verification exp.: simplify secondary tests usage of "prepare_run"#975jm-c merged 19 commits intoMITgcm:masterfrom
Conversation
to prevent linking wrong copy of files from ../input/ and remove/update "prepare_run"
at the end of this prepare_run, so that all needed links will be provided by running just this current prepare_run.
so that it does not require to run primary test "prepare_run"
(i.e., the one linked to run-dir), instead of both "prepare_run" from the secondary test input dir and then from primary test input dir.
|
This PR is not finished, still need to update the README and the docs, but the changes to verification experiments are done and could be reviewed. I had to add a copy of few parameter files (i.e., "data.*") and even two links for pickup file, mostly in experiment |
|
I ran this for fwd and TAF-AD testreport and there are no problems. I find it a little counterintuitive that you need the extra files and links. The fact that these files (e.g. the namelist files in It would mean that many operations are done twice (the second time without any effect), so that may be confusing again. In summary, I don't have a good solution, so we should go with what is here. |
|
I updated the instructions related to And regarding the extra set of parameter files that got added (mainly for Regarding the two pickup files (symbolic links added in |
mjlosch
left a comment
There was a problem hiding this comment.
I followed the instructions in a set of sampled README's and was successful,
LGTM.
|
Update: I tried to shift Also, changing testreport to run only one |
|
I think this PR is ready to be merged, and could do this tomorrow, unless someone wants to add something. |
also remove trailing blanks
What changes does this PR introduce?
Implement changes following issue #964
What is the current behaviour?
In secondary tests "${sfx}", both
prepare_runfrom current "../input. ${sfx}" directory and from primary test input directory "../input" are run, each after links from respective input dir are made.What is the new behaviour
In secondary tests, only run one "prepare_run" (the one linked into the current run-dir) after links from both "../input. ${sfx}" and "../input" are made.
Does this PR introduce a breaking change?
Other information:
Suggested addition to
tag-indexo verification:
from run-dir, after linking file from both ../input.${sfx}/ and ../input/.
instructions in README files + in the docs.