fix(fixtures): fix package detection/selection#60
Merged
Conversation
Merged
wpbonelli
added a commit
that referenced
this pull request
Jan 18, 2023
* ci(release): update to development version 0.1.4 * docs(fixtures): add docs for model filtering by name/package (#52) * docs(install): fix test model repo clone commands (#53) * refactor(has_pkg): use import.metadata instead of pkg_resources (#54) * Update docs (#55) * docs: minor updates to DEVELOPER.md and README.md * docs: add docs for download utilities * docs: update docs for download utilities (#56) * docs: expand docs for MFZipFile (#58) * chore: remove empty files, fix long description in setup.cfg (#59) * fix(fixtures): fix package detection/selection (#60) * ci(release): set version to 0.1.4, update changelog Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: w-bonelli <wbonelli@ucar.edu> Co-authored-by: Mike Taves <mwtoews@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the
get_packages(namefile_path)function was not smart enough to find and search component model namefiles when given a simulation namefile — it only searched the specified namefile, so only GWF, IMS and TDIS would be returned, not the simulation's constituent models' packages. This PR fixes the function, looking in any GWF and GWT model namefiles referenced in a simulation namefile.This affects the
get_namefile_paths()andget_model_paths()functions, which useget_packages()internally. Also makes filtering external model tests by--packagebehave as expected, like the modflow6 autotests'--pakoption previously behaved, including any component model packages used by a simulation.