Update MMM-physics tag in Externals.cfg to fix .F90 re-compilation issue #1337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the tag to 20250616-MPASv8.3 for the MMM-physics external in the src/core_atmosphere/Externals.cfg file to address an issue with .F90 files not being re-compiled to .o files if a .F90 file was modified. With the updated tag, compiling the atmosphere core, then making changes to any of the .F90 files in src/core_atmosphere/physics/physics_mmm/, then running 'make' again (without first cleaning) leads to the modified .F90 files correctly being re-compiled.
weiwangncar
approved these changes
Jun 16, 2025
weiwangncar
approved these changes
Jun 16, 2025
mgduda
added a commit
that referenced
this pull request
Jun 18, 2025
This merge corrects two issues in the MPAS-Atmosphere model: * Fix a bug in the vertical interpolation of humidity for LBCs when first-guess levels are given in top-to-bottom order. Incorrect logic in the init_atm_case_lbc routine previously assumed that first-guess levels would be given in bottom-to-top order when attempting to vertically extrapolate to model levels below the lowest first-guess level, resulting in a copy of the vertically interpolated relative humidity at level k+1 to level k if levels were given in top-to-bottom order. This bug resulted in an unreasonably low water vapor mixing ratio field (lbc_qv) in LBC files. (PR #1335) NB: This bug is present in most older releases of MPAS, and it should be possible to cherry-pick the fix onto any branch or release based on MPAS v7.0 or later. * Fix an issue with .F90 files in the src/core_atmosphere/physics/physics_mmm/ directory not being re-compiled by updating the MMM-physics external tag to acquire a new Makefile.mpas file for MMM-physics. With the updated tag, compiling the atmosphere core, then making changes to any of the .F90 files in src/core_atmosphere/physics/physics_mmm/, then running make again (without first cleaning) leads to the modified .F90 files being correctly re-compiled. (PR #1337)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the tag to
20250616-MPASv8.3for theMMM-physicsexternal in thesrc/core_atmosphere/Externals.cfgfile to address an issue with.F90files not being re-compiled to.ofiles if a.F90file was modified. With the updated tag, compiling the atmosphere core, then making changes to any of the.F90files insrc/core_atmosphere/physics/physics_mmm/, then runningmakeagain (without first cleaning) leads to the modified.F90files correctly being re-compiled.