Skip to content

Adds Delaware flooding case#366

Closed
pwolfram wants to merge 13 commits intoMPAS-Dev:ocean/coastalfrom
pwolfram:coastal/adds_Delaware_sandy_flooding
Closed

Adds Delaware flooding case#366
pwolfram wants to merge 13 commits intoMPAS-Dev:ocean/coastalfrom
pwolfram:coastal/adds_Delaware_sandy_flooding

Conversation

@pwolfram
Copy link
Contributor

@pwolfram pwolfram commented Sep 12, 2019

Adds in Delaware flooding under Hurricane Sandy with wetting and drying used to simulate coastal flooding.

@pwolfram
Copy link
Contributor Author

pwolfram commented Sep 12, 2019

@sbrus89, here is the case we discussed on the phone. Please feel free to push commits to this branch.

@pwolfram
Copy link
Contributor Author

pwolfram commented Sep 12, 2019

Note, this still needs #350 resolved in order to be completely stable over a run (although restarts work).

@pwolfram pwolfram requested a review from sbrus89 September 23, 2019 14:31
@pwolfram
Copy link
Contributor Author

pwolfram commented Oct 16, 2019

@mark-petersen we should merge this based on our discussion. This is COMPASS-only.

@pwolfram
Copy link
Contributor Author

pwolfram commented Oct 16, 2019

@sbrus89 can you please approve when you get a chance?

sbrus89
sbrus89 suggested changes Oct 17, 2019
View reviewed changes
testing_and_setup/compass/ocean/hurricane/USDEQU120at30cr10rr2WD/sandy/config_init.xml Outdated
Comment on lines +1 to +5
Copy link

@sbrus89 sbrus89 Oct 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a init_template.xml in #371. Should we go ahead and use that here?

Copy link
Contributor Author

@pwolfram pwolfram Jan 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump to front

Copy link
Contributor Author

@pwolfram pwolfram Feb 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was resolved, but we should double-check after I swash commits.

@mark-petersen mark-petersen self-requested a review October 17, 2019 19:44
mark-petersen
mark-petersen approved these changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@mark-petersen mark-petersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pwolfram and @sbrus89: When you are happy with this, please merge at will.

@pwolfram pwolfram mentioned this pull request Oct 18, 2019
Merged
@pwolfram
Copy link
Contributor Author

pwolfram commented Oct 18, 2019

@sbrus89, in discussions with @mark-petersen we've decided to wait on this until tides are merged in because this PR really should include tides to bring wetting and drying and tides together.

@pwolfram pwolfram force-pushed the coastal/adds_Delaware_sandy_flooding branch from 1525ab0 to cfa06e2 Compare January 16, 2020 23:59
@pwolfram
Copy link
Contributor Author

pwolfram commented Jan 17, 2020

Note, config_AM_timeSeriesStatsCustom filter with max produces 0 if field is negatives. This needs checked or an issue submitted.

This was referenced Feb 26, 2020
Closed
Open
@pwolfram pwolfram force-pushed the coastal/adds_Delaware_sandy_flooding branch from 90a6d08 to 437c629 Compare February 27, 2020 23:00
@pwolfram
Copy link
Contributor Author

pwolfram commented Feb 28, 2020

Low res is working roughly ok, but still have some issues at high-resolution. Low-resolution is below:

8537121

Some sort of tuning or something else like that is needed for higher resolution than 5km as shown here.

@pwolfram pwolfram mentioned this pull request Apr 1, 2020
Merged
@pwolfram pwolfram mentioned this pull request Apr 14, 2020
Merged
@pwolfram
Copy link
Contributor Author

pwolfram commented Apr 14, 2020

Closing and will build off #520 instead.

@pwolfram pwolfram closed this Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mark-petersen mark-petersen mark-petersen approved these changes

+1 more reviewer

@sbrus89 sbrus89 sbrus89 requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

coastal feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pwolfram @sbrus89 @mark-petersen @matthewhoffman