-
Notifications
You must be signed in to change notification settings - Fork 390
Change global_ocean ISC test cases to use BedMachine #433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mark-petersen
merged 20 commits into
MPAS-Dev:ocean/develop
from
xylar:ocean/compass/add_bedmachine
Mar 23, 2020
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
e50cf52
Add support for computing signed distance in COMPASS
xylar c3ad080
Switch to using a FeatureCollection
xylar 82b9b66
Add draft of SO60to10wISC using the new signed distance
xylar 164fcc2
Update high-res region for SO60to10wISC
xylar 73fc417
Change SO60to10wISC transition width and location
xylar 4398b24
Mask out more points near the +/- 180 lon boundary
xylar 42ff599
Fix periodic boundary for region mask
xylar a3b819a
Fix sign of transition offset
xylar b51bb9f
Fix periodic mask again
xylar a5889a4
Make lon/lat hit -180 and 180 exactly
xylar b7244d2
Alter drake passage res
xylar c21db53
Fix config_base_mesh for SO60to10wISC
xylar 343503b
Change global_ocean ISC test cases to use BedMachine
xylar 3fc0fc7
Remove unused land-ice base mesh
xylar 287532b
Switch Antarctic coastline feature to BedMachine
xylar 50df66a
Update dims in template for BedMachine topo
xylar 7364897
Add a date to the new topo file
xylar ccb7466
Rename run_test.py --> run.py in spin-up steps
xylar bdf07fb
Give EC60to30wISC initil_state with 60 levels
xylar eae6b5e
Get landIceMask from geometric_features
xylar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
2 changes: 1 addition & 1 deletion
2
testing_and_setup/compass/ocean/global_ocean/CUSP12/spin_up/config_driver.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
testing_and_setup/compass/ocean/global_ocean/CUSP8/spin_up/config_driver.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
testing_and_setup/compass/ocean/global_ocean/EC60to30/spin_up/config_driver.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 0 additions & 1 deletion
1
testing_and_setup/compass/ocean/global_ocean/EC60to30wISC/init/config_initial_state.xml
This file was deleted.
Oops, something went wrong.
59 changes: 59 additions & 0 deletions
59
testing_and_setup/compass/ocean/global_ocean/EC60to30wISC/init/config_initial_state.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| <?xml version="1.0"?> | ||
| <config case="initial_state"> | ||
| <get_file dest_path="initial_condition_database" file_name="PotentialTemperature.01.filled.60levels.PHC.151106.nc"> | ||
| <mirror protocol="wget" url="https://web.lcrc.anl.gov/public/e3sm/mpas_standalonedata/mpas-ocean/initial_condition_database/"/> | ||
| </get_file> | ||
|
|
||
| <get_file dest_path="initial_condition_database" file_name="Salinity.01.filled.60levels.PHC.151106.nc"> | ||
| <mirror protocol="wget" url="https://web.lcrc.anl.gov/public/e3sm/mpas_standalonedata/mpas-ocean/initial_condition_database/"/> | ||
| </get_file> | ||
|
|
||
|
|
||
| <get_file dest_path="initial_condition_database" file_name="windStress.ncep_1958-2000avg.interp3600x2431.151106.nc"> | ||
| <mirror protocol="wget" url="https://web.lcrc.anl.gov/public/e3sm/mpas_standalonedata/mpas-ocean/initial_condition_database/"/> | ||
| </get_file> | ||
|
|
||
| <get_file dest_path="bathymetry_database" file_name="BedMachineAntarctica_and_GEBCO_2019_0.05_degree.200128.nc"> | ||
| <mirror protocol="wget" url="https://web.lcrc.anl.gov/public/e3sm/mpas_standalonedata/mpas-ocean/bathymetry_database/"/> | ||
| </get_file> | ||
|
|
||
| <get_file dest_path="initial_condition_database" file_name="chlorophyllA_monthly_averages_1deg.151201.nc"> | ||
| <mirror protocol="wget" url="https://web.lcrc.anl.gov/public/e3sm/mpas_standalonedata/mpas-ocean/initial_condition_database/"/> | ||
| </get_file> | ||
|
|
||
|
|
||
| <add_link source="../culled_mesh/culled_mesh.nc" dest="mesh.nc"/> | ||
| <add_link source="../culled_mesh/culled_graph.info" dest="graph.info"/> | ||
| <add_link source="../culled_mesh/critical_passages_mask_final.nc" dest="critical_passages.nc"/> | ||
| <add_link source_path="initial_condition_database" source="Salinity.01.filled.60levels.PHC.151106.nc" dest="layer_depth.nc"/> | ||
| <add_link source_path="initial_condition_database" source="PotentialTemperature.01.filled.60levels.PHC.151106.nc" dest="temperature.nc"/> | ||
| <add_link source_path="initial_condition_database" source="Salinity.01.filled.60levels.PHC.151106.nc" dest="salinity.nc"/> | ||
| <add_link source_path="initial_condition_database" source="windStress.ncep_1958-2000avg.interp3600x2431.151106.nc" dest="wind_stress.nc"/> | ||
| <add_link source_path="bathymetry_database" source="BedMachineAntarctica_and_GEBCO_2019_0.05_degree.200128.nc" dest="topography.nc"/> | ||
| <add_link source_path="initial_condition_database" source="chlorophyllA_monthly_averages_1deg.151201.nc" dest="swData.nc"/> | ||
|
|
||
| <namelist name="namelist.ocean" mode="init"> | ||
| <template file="template_initial_state.xml" path_base="script_configuration_dir"/> | ||
| <template file="template_critical_passages.xml" path_base="script_core_dir" path="global_ocean"/> | ||
| <template file="template_init_with_land_ice.xml" path_base="script_configuration_dir"/> | ||
| <option name="config_iterative_init_variable">'landIcePressure_from_top_density'</option> | ||
| <option name="config_global_ocean_depth_file">'layer_depth.nc'</option> | ||
| <option name="config_global_ocean_minimum_depth">10</option> | ||
| <option name="config_global_ocean_deepen_critical_passages">.false.</option> | ||
| <option name="config_global_ocean_depth_conversion_factor">0.01</option> | ||
| <option name="config_global_ocean_tracer_depth_conversion_factor">0.01</option> | ||
| </namelist> | ||
|
|
||
| <streams name="streams.ocean" keep="immutable" mode="init"> | ||
| <template file="template_initial_state.xml" path_base="script_configuration_dir"/> | ||
| <template file="template_critical_passages.xml" path_base="script_core_dir" path="global_ocean"/> | ||
| </streams> | ||
|
|
||
| <run_script name="run.py"> | ||
| <step executable="gpmetis"> | ||
| <argument flag="graph.info">4</argument> | ||
| </step> | ||
| <model_run procs="4" threads="1" namelist="namelist.ocean" streams="streams.ocean"/> | ||
| </run_script> | ||
|
|
||
| </config> |
2 changes: 1 addition & 1 deletion
2
testing_and_setup/compass/ocean/global_ocean/EC60to30wISC/spin_up/config_driver.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
testing_and_setup/compass/ocean/global_ocean/QU60/spin_up/config_driver.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 0 additions & 1 deletion
1
testing_and_setup/compass/ocean/global_ocean/SO60to10wISC/init/config_base_mesh.xml
This file was deleted.
Oops, something went wrong.
13 changes: 13 additions & 0 deletions
13
testing_and_setup/compass/ocean/global_ocean/SO60to10wISC/init/config_base_mesh.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| <?xml version="1.0"?> | ||
| <config case="base_mesh"> | ||
|
|
||
| <add_link source_path="mpas_model" source="testing_and_setup/compass/ocean/jigsaw_to_MPAS" dest="jigsaw_to_MPAS"/> | ||
| <add_link source_path="script_test_dir" source="." dest="define_base_mesh"/> | ||
| <add_link source_path="script_test_dir" source="high_res_region.geojson" dest="high_res_region.geojson"/> | ||
|
|
||
| <run_script name="run.py"> | ||
| <step executable="python"> | ||
| <argument flag="-m">jigsaw_to_MPAS.build_mesh</argument> | ||
| </step> | ||
| </run_script> | ||
| </config> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73 changes: 73 additions & 0 deletions
73
..._and_setup/compass/ocean/global_ocean/SO60to10wISC/init/high_res_region.geojson
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| { | ||
| "type": "FeatureCollection", | ||
| "features": [ | ||
| { | ||
| "type": "Feature", | ||
| "properties": { | ||
| "name": "SO60to10 high res region", | ||
| "component": "ocean", | ||
| "object": "region", | ||
| "author": "Xylar Asay-Davis" | ||
| }, | ||
| "geometry": { | ||
| "type": "Polygon", | ||
| "coordinates": [ | ||
| [ | ||
| [ | ||
| -75.5859375, | ||
| -48.92249926375823 | ||
| ], | ||
| [ | ||
| -96.50390625, | ||
| -54.67383096593114 | ||
| ], | ||
| [ | ||
| -124.45312499999999, | ||
| -53.95608553098789 | ||
| ], | ||
| [ | ||
| -180, | ||
| -53 | ||
| ], | ||
| [ | ||
| -180, | ||
| -90 | ||
| ], | ||
| [ | ||
| 180, | ||
| -90 | ||
| ], | ||
| [ | ||
| 180, | ||
| -53 | ||
| ], | ||
| [ | ||
| 168.3984375, | ||
| -51.17934297928927 | ||
| ], | ||
| [ | ||
| 121.640625, | ||
| -45.82879925192133 | ||
| ], | ||
| [ | ||
| 22.148437499999996, | ||
| -37.99616267972812 | ||
| ], | ||
| [ | ||
| -61.17187499999999, | ||
| -34.30714385628803 | ||
| ], | ||
| [ | ||
| -68.90625, | ||
| -40.97989806962013 | ||
| ], | ||
| [ | ||
| -75.5859375, | ||
| -48.92249926375823 | ||
| ] | ||
| ] | ||
| ] | ||
| } | ||
| } | ||
| ] | ||
| } |
2 changes: 1 addition & 1 deletion
2
testing_and_setup/compass/ocean/global_ocean/SO60to10wISC/spin_up/config_driver.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
testing_and_setup/compass/ocean/global_ocean/SOQU60to15/spin_up/config_driver.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 0 additions & 13 deletions
13
testing_and_setup/compass/ocean/global_ocean/config_files/config_base_mesh_land_ice.xml
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
testing_and_setup/compass/ocean/global_ocean/config_files_ISC/template_initial_state.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| <template> | ||
| <streams> | ||
| <stream name="land_ice_mask_init"> | ||
| <attribute name="type">input</attribute> | ||
| <attribute name="filename_template">land_ice_mask.nc</attribute> | ||
| <add_contents> | ||
| <member name="landIceMask" type="var"/> | ||
| </add_contents> | ||
| </stream> | ||
| </streams> | ||
| </template> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and similar lines in other
spin_updriver scripts seem like they should be changed as above to be consistent withinitdriver scripts. @mark-petersen, let me know if you disagree.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. Easier to be consistent and only use run.py