Optionally add links to load_compass_env.sh in test cases#492
Merged
mark-petersen merged 10 commits intoMPAS-Dev:ocean/developfrom Apr 10, 2020
Merged
Conversation
sbrus89
reviewed
Apr 3, 2020
sbrus89
left a comment
sbrus89
left a comment
There was a problem hiding this comment.
@xylar, I tested setting up cases with both the command line and config file options. In both cases, the load_compass_env.sh links worked for me (with the exception that compass_0.1.3 isn't available at this point).
I didn't test the changes in build_mesh.py, cull_mesh.py, and create_E3SM_coupling_file.py. Should these changes come in via a different PR?
Thanks for adding this feature!
Collaborator
Author
This merge moves soma/4km/32to4km and soma/8km/32to8km test cases into a new subdirectory called "broken" since these test cases are not working and won't be fixed anytime soon. With this change, `./list_testcases.py` and `./setup_testcases.py` won't pick up these tests because their driver config files aren't at the expected directory level.
The Maine, QU60 and SOQU60to15 test cases now have the links to the python script for defining their vertical grids that they need to be set up successfully.
We no longer define a path to metis in the config file, so the version from the conda environment needs to be used instead.
Add support for a "conda_mpi" attribute to "step" tags. If this attribute is set to "true" and MPI is present in the conda environment, that command will be called with `mpirun` from the conda envrionment. This is needed to support compass conda enviornments with mpich. Python scripts and modules that use the netcdf4 package with mpich support don't work properly on many compute nodes (e.g. Grizzly at LANL and Anvil at ANL) unless they are prefixed with `mpirun -np 1`
The paraview extractor can now be called as a function rather than a script, and this is done during base-mesh generation and culling. SCRIP files can now also be created with a function, so a script call is replaced with a function here as well. With these changes, calls to python scripts that use NetCDF in the parallel conda enviornment will now work as long as they are called with `mpirun -np 1`
Also rename the load script for convenience.
This will make sure the compatible version of MPI gets used.
Since we can't detect automatically that this is a python script, (and that it needs to support compass mpi) we need to say so explicitly
This is specified either in the config file or at the command line.
xylar
force-pushed
the
add_load_compass_env_to_test_cases
branch
from
c6099b4 to
0c49222
Compare
Collaborator
Author
|
@mark-petersen, this has been rebased onto #480 and should also now be ready for testing and merge. |
mark-petersen
approved these changes
Apr 10, 2020
Contributor
mark-petersen
left a comment
mark-petersen
left a comment
There was a problem hiding this comment.
Looks good. Passes nightly test suite with new compass tag.
caozd999
pushed a commit
to caozd999/MPAS-Model
that referenced
this pull request
Jan 14, 2021
… ocean/develop Optionally add links to load_compass_env.sh in test cases MPAS-Dev#492 This is specified either in the config file or at the command line. Like MPAS-Dev#480, this involves changes to common COMPASS infrastructure and we should consider making a separate PR to develop instead of merging those changes to ocean/develop. closes MPAS-Dev#490
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is specified either in the config file or at the command line.
Like #480, this involves changes to common COMPASS infrastructure and we should consider making a separate PR to
developinstead of merging those changes toocean/develop.closes #490