Fixes implicitCd computation bug in mpas_ocn_vmix.F#566
Merged
pwolfram merged 1 commit intoMPAS-Dev:ocean/coastalfrom May 19, 2020
Merged
Conversation
caozd999
changed the title
caozd999
changed the title
caozd999
changed the title
Contributor
|
@caozd999, can you please do a rebase (or cherry-pick |
caozd999
force-pushed
the
coastal/variable_bottom_drag_fix_bugs_implicitCd
branch
from
7c0c5d0 to
6ac44b2
Compare
pwolfram
approved these changes
May 19, 2020
mark-petersen
approved these changes
May 19, 2020
Contributor
mark-petersen
left a comment
mark-petersen
left a comment
There was a problem hiding this comment.
approved by visual inspection and conversation with @pwolfram
Contributor
|
Thanks @caozd999 for the great catch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the computation of implicitCd in shared/mpas_ocn_vmix.F subroutine
subroutine ocn_vel_vmix_tend_implicit_spatially_variable_mannings
The original code is
and should be