Add idealized marsh flooding case with vegetation drag#651
Merged
sbrus89 merged 3 commits intoMPAS-Dev:ocean/coastalfrom Aug 18, 2020
Merged
Conversation
Author
|
@sbrus89, please let me know if you have any comments. Thanks! |
|
@caozd999, could you cherry-pick your last two commits onto ocean/coastal one more time. We had to do another rebase onto ocean/develop. After you do that, I'll test and merge. |
Author
1) add a transect mesh 2) add idealized_transect case in marsh_flooding
coastal transect with (1) no vegetation (2) vegetation, constant Manning value (3) vegetation, vegetation-induced Manning value
caozd999
force-pushed
the
coastal/marshFlooding_PR_cherrypick
branch
from
25abd12 to
f645e60
Compare
sbrus89
reviewed
Aug 17, 2020
testing_and_setup/compass/ocean/drying_slope/forward_idealized_transect.xml
Outdated
Show resolved
Hide resolved
sbrus89
reviewed
Aug 17, 2020
testing_and_setup/compass/ocean/drying_slope/init_idealized_transect.xml
Show resolved
Hide resolved
sbrus89
reviewed
Aug 17, 2020
testing_and_setup/compass/ocean/drying_slope/marsh_flooding/idealized_transect/config_init1.xml
Outdated
Show resolved
Hide resolved
sbrus89
reviewed
Aug 17, 2020
testing_and_setup/compass/ocean/drying_slope/meshes/transect/config_driver.xml
Show resolved
Hide resolved
sbrus89
reviewed
Aug 17, 2020
testing_and_setup/compass/ocean/drying_slope/init_idealized_transect.xml
Outdated
Show resolved
Hide resolved
sbrus89
reviewed
Aug 17, 2020
...g_and_setup/compass/ocean/drying_slope/marsh_flooding/idealized_transect/config_forward1.xml
Outdated
Show resolved
Hide resolved
caozd999
force-pushed
the
coastal/marshFlooding_PR_cherrypick
branch
from
514d890 to
62a7d20
Compare
sbrus89
reviewed
Aug 18, 2020
There was a problem hiding this comment.
@caozd999, there should be a source_path specified here for when cases are setup in different working directories
There was a problem hiding this comment.
I believe it should be:
<add_link source_path="script_test_dir" source="comparison.py" dest="comparison.py"/>
caozd999
force-pushed
the
coastal/marshFlooding_PR_cherrypick
branch
from
62a7d20 to
9b03cfb
Compare
caozd999
force-pushed
the
coastal/marshFlooding_PR_cherrypick
branch
from
9b03cfb to
1570beb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the sibling of #639 and a substitute of #552.
In this PR, an idealized Delaware Bay coastal transect is defined as the combination of three parts from land to ocean: (1) coast (2) marsh land (where vegetation may occupy) and (3) offshore; each part is defined by its length and slope. Three test cases are set up by considering vegetation drag differently: (1) with no vegetation, and no vegetation drag; (2) with vegetation, represented by constant vegetation Manning's roughness (0.065, Dietrich et al., 2011); (3) with vegetation, represented by vegetation-induced Manning's roughness (equations of Moki et al., 2020). The test cases are driven by a semi-diurnal tidal boundary condition with tidal amplitude as 1.5 m. A new transect mesh is generated for this marsh flooding case.
Results
(1) tidal amplitudes at the OB
(2) tidal water level along the transect
References