Update Earth radius to the CIME value#680
Merged
mark-petersen merged 24 commits intoMPAS-Dev:ocean/developfrom Sep 3, 2020
Merged
Update Earth radius to the CIME value#680mark-petersen merged 24 commits intoMPAS-Dev:ocean/developfrom
mark-petersen merged 24 commits intoMPAS-Dev:ocean/developfrom
Conversation
Collaborator
Author
Collaborator
Author
|
These changes are not bit-for-bit so I could use some help thinking about how to test them. |
Collaborator
Author
Testing on GrizzlyVerification that the test runs to completion:
|
Collaborator
Author
|
|
Contributor
|
Yes, I cherry-picked #676 for spin-up steps. I'll get that one on soon. |
26 tasks
Contributor
|
See initial state plots: #577 (comment) |
sbrus89
approved these changes
Sep 3, 2020
sbrus89
left a comment
There was a problem hiding this comment.
Approved, based on inspection of hurricane/USDEQU240at60cr20rr4WD case.
This was referenced Sep 4, 2020
Collaborator
Author
|
Thanks very much @sbrus89 and @mark-petersen for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, COMPASS uses 3 different Earth radii. With this merge and a corresponding update to MPAS-Tools, all Earth radii are the CIME value.
This PR addresses #549 along with MPAS-Dev/MPAS-Tools#341.