Skip to content

Update conda package and compass to better support MPI#303

Merged
xylar merged 10 commits intoMPAS-Dev:masterfrom
xylar:update_conda_package_for_mpi
Apr 9, 2020
Merged

Update conda package and compass to better support MPI#303
xylar merged 10 commits intoMPAS-Dev:masterfrom
xylar:update_conda_package_for_mpi

Conversation

@xylar
Copy link
Collaborator

@xylar xylar commented Mar 20, 2020

This merge makes two scripts into stubs so that the functionality from the scripts is fully available through functions within the mpas_tools package:

  • The functionality of the paraview VTK extractor is now in mpas_tools.viz.paraview_extractor
  • Creation of SCRIP files from MPAS meshes is now in mpas_tools.scrip.from_mpas
    The scripts for this functionality still exist but are just stubs that call the functions.

These changes allow VTK and SCRIP files to be created directly within python scripts, rather than through awkward subprocess calls that are causing trouble for conda environments with MPI support.

This merge also updates to the compass metapckage to 0.1.3:

  • updates mpas_tools to 0.1.10 (not yet released)
  • adds rasterio
  • adds affine
  • adds ipython
  • adds jupyter

closes #305

xylar added 4 commits March 20, 2020 16:47
This allows users to call it as a function, rather than just as
a command-line tool.
Keep existing script just as a stub.
Updates:
* mpas_tools to 0.1.10

Adds:
* rastio
* affine
@xylar
Copy link
Collaborator Author

xylar commented Mar 20, 2020

Testing

I test-build the packages using these steps for building the packages and installing this version of mpas_tools and compass in a test environment:

source ~/miniconda3/etc/profile.d/conda.sh
conda activate base
# if needed:
conda install -y conda-build
conda update -y conda conda-build
rm -rf ~/miniconda3/conda-bld/
conda build --python=3.7 conda_package/recipe/
conda build compass/
conda create -y -n test_compass --use-local "compass=0.1.3=mpi_mpich*"
conda activate test_compass

Then, I ran the QU240wISC COMPASS test case from MPAS-Dev/MPAS-Model#480

@xylar
Copy link
Collaborator Author

xylar commented Mar 20, 2020

The rasterio and affine packages are needed by MPAS-Dev/MPAS-Model#473, the work for making meshes with a signed-distance function.

Copy link
Contributor

@pwolfram pwolfram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by visual inspection.

Copy link
Collaborator

@mark-petersen mark-petersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks for the upkeep. @xylar I'm guessing you can merge this, and we can then merge MPAS-Dev/MPAS-Model#480 after that when we are ready?

@xylar
Copy link
Collaborator Author

xylar commented Apr 2, 2020

@mark-petersen, I think considerably more testing of this COMPASS with MPI is needed before this is ready to merge. I have been waiting for us to get spun-up initial conditions for the EC60to30 configurations (and the changes related to those) before I start doing testing again. I should be able to start on that later today or tomorrow.

@xylar
Copy link
Collaborator Author

xylar commented Apr 9, 2020

This version of the mpas_tools package and compass environment have been tested thoroughly as part of MPAS-Dev/MPAS-Model#480. Merging and releasing...

@xylar xylar merged commit 2957b79 into MPAS-Dev:master Apr 9, 2020
@xylar xylar deleted the update_conda_package_for_mpi branch April 9, 2020 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Addition of ipython to compass environment

3 participants