Convert masks to int type in cull() function#521
Merged
xylar merged 2 commits intoMPAS-Dev:masterfrom Aug 18, 2023
Merged
Conversation
xylar
force-pushed
the
type-conversion-in-cull
branch
3 times, most recently
from
ff12f8e to
dbdfb22
Compare
xylar
force-pushed
the
type-conversion-in-cull
branch
from
dbdfb22 to
09626a4
Compare
Collaborator
Author
TestingI was able to cull the mesh in the QUwISC240 and RRSwISC6to18 mesh test cases with output in NETCDF4 format in compass with this branch, whereas it was crashing without these changes. |
The new version of the cell culler requires masks in int (rather than int64 or float) format.
xylar
force-pushed
the
type-conversion-in-cull
branch
from
09626a4 to
45291ef
Compare
1 task
xylar
added a commit
to xylar/MPAS-Tools
that referenced
this pull request
Nov 4, 2025
This debug output was inadvertently left in MPAS-Dev#521
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new version of the cell culler requires masks in
int(rather thanint64orfloat) format.This is needed because output in NETCDF4 format is producing int64, rather than int32, arrays but the cell culller is then reading a full int64 data array into memory allocated for an int32 array, thus overwriting a lot of memory allocated for other arrays with garbage.