Add ocean topography smoothing tool#538
Merged
xylar merged 2 commits intoMPAS-Dev:masterfrom Nov 21, 2023
Merged
Conversation
Collaborator
Author
|
@maltrud, I'm able to build the tool! On to Compass. |
xylar
force-pushed
the
add-smooth-topo-tool
branch
from
54576b2 to
e9cd35d
Compare
xylar
force-pushed
the
add-smooth-topo-tool
branch
3 times, most recently
from
2c09ab8 to
be3b239
Compare
xylar
force-pushed
the
add-smooth-topo-tool
branch
from
be3b239 to
ef25978
Compare
This was referenced Nov 19, 2023
Collaborator
Author
TestingI used this to produce smoothed bathymetry and ice-shelf topography for the ECwISC and IcoswISC meshes in MPAS-Dev/compass#733 and MPAS-Dev/compass#734.
|
maltrud
approved these changes
Nov 21, 2023
maltrud
left a comment
maltrud
left a comment
There was a problem hiding this comment.
Looks good to me. the guts of the algorithm that I used in my stand-alone code are replicated here, with extensions to handle ice shelf cavities.
Collaborator
Author
|
Excellent, thank you, @maltrud! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tool will be used in Compass to smooth topography for EC and Icos30 meshes (perhaps others in the future).