Switch global ocean forward steps to use graph.info from initial state, not mesh#203
Merged
xylar merged 2 commits intoMPAS-Dev:masterfrom Aug 10, 2021
Merged
Conversation
This merge also switches to f-strings for better readability.
This means forward steps depend only in steps from the init test case, not the mesh test case, which should decrease dependencies when running cached versions of each test case.
xylar
added
ocean
clean-up
python package
xylar
commented
Aug 9, 2021
Comment on lines
-136
to
+135
| for file in ['initial_state.nc', 'init_mode_forcing_data.nc']: | ||
| for file in ['initial_state.nc', 'init_mode_forcing_data.nc', | ||
| 'graph.info']: |
Collaborator
Author
There was a problem hiding this comment.
This is one of two main change.
xylar
commented
Aug 9, 2021
Comment on lines
-118
to
+116
| work_dir_target='{}/culled_graph.info'.format(mesh_path)) | ||
| work_dir_target=f'{init.path}/initial_state/graph.info') |
Collaborator
Author
There was a problem hiding this comment.
This is the other main change.
Collaborator
Author
|
@mark-petersen, could you run a quick test on this before I merge and rebase #184? |
mark-petersen
approved these changes
Aug 10, 2021
Collaborator
mark-petersen
left a comment
mark-petersen
left a comment
There was a problem hiding this comment.
Yes! This works great!
compass setup -w $n/210810_pr_cache_3 -n 81c 82
Setting up test cases:
ocean/global_ocean/EC30to60/PHC/init
steps with cached outputs: initial_state
Downloading initial_state.210809.nc (1.8GiB)
to /usr/projects/regionalclimate/COMMON_MPAS/ocean/grids/compass_cache/global_ocean/EC30to60/PHC/init/initial_state
100% |################################################################################################################| Time: 0:02:50
initial_state.210809.nc done.
Downloading init_mode_forcing_data.210809.nc (14.5MiB)
to /usr/projects/regionalclimate/COMMON_MPAS/ocean/grids/compass_cache/global_ocean/EC30to60/PHC/init/initial_state
100% |################################################################################################################| Time: 0:00:01
init_mode_forcing_data.210809.nc done.
Downloading graph.210809.info (9.0MiB)
to /usr/projects/regionalclimate/COMMON_MPAS/ocean/grids/compass_cache/global_ocean/EC30to60/PHC/init/initial_state
100% |################################################################################################################| Time: 0:00:01
graph.210809.info done.
ocean/global_ocean/EC30to60/PHC/performance_test
target cores: 128
minimum cores: 36
I successfully set up and ran these combinations on grizzly:
compass setup -w $n/210810_pr_cache_3 -n 81c 82
Setting up test cases:
ocean/global_ocean/EC30to60/PHC/init
steps with cached outputs: initial_state
ocean/global_ocean/EC30to60/PHC/performance_test
target cores: 128
minimum cores: 36
$ compass setup -w $n/210810_pr_cache_2 -n 41c 42
Setting up test cases:
ocean/global_ocean/QU240/PHC/init
steps with cached outputs: initial_state
ocean/global_ocean/QU240/PHC/performance_test
target cores: 4
minimum cores: 1
$ compass setup -w $n/210810_pr_cache_1 -n 61c 62
Setting up test cases:
ocean/global_ocean/QUwISC240/PHC/init
steps with cached outputs: initial_state ssh_adjustment
ocean/global_ocean/QUwISC240/PHC/performance_test
target cores: 4
minimum cores: 4
and ran and they all worked great! I also set up everything on cori, and everything worked.
Collaborator
Author
|
Thanks @mark-petersen! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge also adds
graph.infoas an output in theinitial_statestep so it is available to subsequent test cases and steps.This change means that forward steps depend only in steps from the init test case, not the mesh test case, which should decrease dependencies when running cached versions of each test case (#184).
Various strings have also been switched from the less readable
.format()syntax to the more readable f-string syntax.