Skip to content

Update MALI-Dev submodule#492

Merged
matthewhoffman merged 1 commit intoMPAS-Dev:mainfrom
matthewhoffman:landice/update_submodule
Jan 13, 2023
Merged

Update MALI-Dev submodule#492
matthewhoffman merged 1 commit intoMPAS-Dev:mainfrom
matthewhoffman:landice/update_submodule

Conversation

@matthewhoffman
Copy link
Member

@matthewhoffman matthewhoffman commented Jan 9, 2023

Update MALI-Dev submodule to ace160c641. This is the final version used for ISMIP6-Antarctica 2300

Checklist

  • The MALI-Dev submodule has been updated with relevant MALI changes
  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

Update MALI-Dev submodule to ace160c641
@matthewhoffman matthewhoffman added land ice in progress This PR is not ready for review or merging labels Jan 9, 2023
@matthewhoffman
Copy link
Member Author

Testing

full_integration suite passes with a few known failures.

@matthewhoffman matthewhoffman removed the in progress This PR is not ready for review or merging label Jan 9, 2023
@matthewhoffman matthewhoffman requested a review from xylar January 9, 2023 22:32
@matthewhoffman
Copy link
Member Author

@xylar , I tagged you to review because we haven't done one of these submodule updates very often. Feel free to remove yourself or replace yourself with Trevor.

@xylar
Copy link
Collaborator

xylar commented Jan 9, 2023

Happy to do it!

@xylar
Copy link
Collaborator

xylar commented Jan 9, 2023

@matthewhoffman, which machine did you test on above? I'll test on something different.

@xylar
Copy link
Collaborator

xylar commented Jan 10, 2023

@matthewhoffman, I tried to test this on Chicoma but didn't quite manage before it went into DST. I'm trying now on Compy.

@xylar
Copy link
Collaborator

xylar commented Jan 10, 2023

@matthewhoffman, I'm seeing lots of failures on Compy. They look something like:

CRITICAL ERROR: block_decomp_all_edges_in_block: Listed fewer edges than expected.

That sounds vaguely familiar but I haven't been able to find a previous mention of this error.

I'll try again with the old submodule to see if it's just a Compy problem.

@xylar
Copy link
Collaborator

xylar commented Jan 10, 2023

Aaaargh! I'm giving up on Compy! I went back to the old submodule and I get:

  225 |       call MPI_ALLREDUCE(localTmp, globalTmp, 1, MPI_DOUBLE_COMPLEX, &
      |                         1
......
 6407 |       call MPI_ALLREDUCE(localSum, globalSum, nFields, &
      |                         2
Error: Type mismatch between actual argument at (1) and actual argument at (2) (COMPLEX(8)/INTEGER(8)).
make[3]: *** [mpas_global_s

@xylar
Copy link
Collaborator

xylar commented Jan 11, 2023

I ran the full_integration test suite on Chrysalis with this branch. All tests were successful except:

landice/humboldt/mesh-3km_restart_test/velo-fo_calving-von_mises_stress_damage-threshold_faceMelting

as we have noted. I made an issue for this on MALI-Dev: MALI-Dev/E3SM#60.

@xylar
Copy link
Collaborator

xylar commented Jan 11, 2023

@matthewhoffman, please merge when you're ready.

@matthewhoffman matthewhoffman merged commit 4cac01f into MPAS-Dev:main Jan 13, 2023
@matthewhoffman matthewhoffman deleted the landice/update_submodule branch January 13, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants