Simplify global ocean dynamic adjustment test cases#682
Merged
xylar merged 12 commits intoMPAS-Dev:mainfrom Aug 25, 2023
Merged
Simplify global ocean dynamic adjustment test cases#682xylar merged 12 commits intoMPAS-Dev:mainfrom
xylar merged 12 commits intoMPAS-Dev:mainfrom
Conversation
This will greatly simplify development of dynamic adjustment for new meshes.
2b4e687 to
cf821cd
Compare
Collaborator
Author
TestingAll tests were with the default compilers and MPI on Chrysalis. I have successfully run the IcoswISC240 and ECwISC30to60 test cases with this branch through dynamic adjustment (the latter required a reduction in the max Haney number, which has been added to #666). I have also successfully run the Other meshes are expensive to test so they will be fine-tuned as part of their respective PRs (#667, #668, #669, etc.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This greatly simplifies the
dynamic_adjustmenttest case in theglobal_oceantest group. Rather than having to define dynamic adjustment steps in python, they are defined based on config options in a yaml file:This is vastly more readable, less error prone and easier to modify during the development process. The flip side is that they are not as flexible, but this seems like a reasonable price to pay. So far, the dynamic adjustment process for all our meshes follows this process. If the ability to modify more namelist options is desirable in the future, we can build this in as well.
Checklist
api.rst) has any new or modified class, method and/or functions listedTestingin this PR) any testing that was used to verify the changes