Merged
Conversation
Collaborator
Author
|
I'm seeing large, non-bit-for-bit changes between E3SM-Project/E3SM#5857 and E3SM-Project/E3SM#5910. I need to find out why, since neither of these PRs explains the changes. |
Collaborator
Author
|
The non BFB changes mentioned above were from E3SM-Project/E3SM#5892 and are expected because that PR fixed the submesoscale parameterization for standalone runs. All non-BFB changes are accounted for so it seems safe (and like a very good idea) to advance the submodule. |
Collaborator
Author
|
I'm holding off on this until I can finish making mesh files for #706, which is in progress. That PR uses the MPAS-Ocean build in my main branch, so I don't want to update it with non-BFB changes (especially accidentally) until that's done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge updates the E3SM-Project submodule from 86f7e8b to 894b5b2.
This update includes the following MPAS-Ocean and MPAS-Frameworks PRs (check mark indicates bit-for-bit with previous PR in the list):