Skip to content

Add BedMachine Antarctica coastline features#126

Merged
xylar merged 4 commits intoMPAS-Dev:masterfrom
xylar:add_bedmachine_coastlines
Feb 11, 2020
Merged

Add BedMachine Antarctica coastline features#126
xylar merged 4 commits intoMPAS-Dev:masterfrom
xylar:add_bedmachine_coastlines

Conversation

@xylar
Copy link
Collaborator

@xylar xylar commented Jan 26, 2020

Also adds a feature creation script to produce these coastlines from the BedMachine Antarctica data set

Fixes some typos in the documentation on adding new features.

@xylar xylar self-assigned this Jan 26, 2020
@xylar
Copy link
Collaborator Author

xylar commented Feb 11, 2020

Testing

This has been tested on several test cases documented in MPAS-Dev/MPAS-Model#433 and seems to behave as expected.

@xylar
Copy link
Collaborator Author

xylar commented Feb 11, 2020

I'm going to go ahead and merge, and then make the 0.1.5 release with the understanding that we could always update the feature if bugs are found later. It is a lot easier to test with the "official" geometric_features package from conda-forge than a test build.

@xylar xylar merged commit 4b7cb4f into MPAS-Dev:master Feb 11, 2020
@xylar xylar deleted the add_bedmachine_coastlines branch February 11, 2020 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant