Fix review feedback: clean up imports, restore tests, fix charge rate bounds logic, remove MQTT retain

[Copilot]

• Remove redundant sys.path manipulation and unused imports in tests/batcontrol/test_core.py
• Add missing tests for api_set_production_offset (valid value 0.7 and negative invalid value) in tests/batcontrol/test_production_offset.py
• Fix bounding logic in core.py limit_battery_charge_rate to properly handle min_pv_charge_rate > max_pv_charge_rate
• Remove retain=True from publish_limit_battery_charge_rate in mqtt_api.py
• Move min_pv_charge_rate > max_pv_charge_rate guard into __init__() (fires warning once at startup, clamps self.min_pv_charge_rate so limit_battery_charge_rate() can rely on the invariant)
• Read max_pv_charge_rate from config['inverter'] first (with inverter attribute as fallback) to avoid MagicMock comparison issues in tests

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[Copilot]

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• test.example.com
  • Triggering command: /usr/bin/python python -m pytest tests/ --cov=src/batcontrol --log-cli-level=DEBUG --log-cli-format=%(asctime)s [%(levelname)8s] %(name)s: %(message)s --log-cli-date-format=%Y-%m-%d %H:%M:%S (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[MaStr]

Please move the guard against the min_max problems in the initialization area, assuming that these values are non changable parameters from the config file @copilot

[Copilot]

Please move the guard against the min_max problems in the initialization area, assuming that these values are non changable parameters from the config file @copilot

Done in commit 274fa8e. The min_pv_charge_rate > max_pv_charge_rate check now runs once at __init__() time (lines 152–167 in core.py): a warning is logged and self.min_pv_charge_rate is permanently clamped to self.max_pv_charge_rate. limit_battery_charge_rate() can now rely on the invariant without any per-call guard logic. Also switched max_pv_charge_rate to be read from config['inverter'] first (falling back to the inverter attribute) for correctness when the value is in the config.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• test.example.com
  • Triggering command: /usr/bin/python python -m pytest tests/ --cov=src/batcontrol --log-cli-level=DEBUG --log-cli-format=%(asctime)s [%(levelname)8s] %(name)s: %(message)s --log-cli-date-format=%Y-%m-%d %H:%M:%S (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)