Skip to content
This repository was archived by the owner on May 3, 2023. It is now read-only.

Conversation

@lithomas1
Copy link
Contributor

@lithomas1 lithomas1 commented Jul 10, 2021

Mirroring some changes we made in the other repo.

Not bumping windows since we are redistributing some dlls from Visual Studio 2017, and it might be risky to upgrade Visual Studio.
See below

@lithomas1
Copy link
Contributor Author

I think we can probably bump windows for 1.4, since the rc will probably catch the errors(if any exist).

@lithomas1
Copy link
Contributor Author

cc @simonjayhawkins

@simonjayhawkins
Copy link
Collaborator

since the rc will probably catch the errors(if any exist).

The nightly builds are from master, so issues should be caught before the rc.

@lithomas1
Copy link
Contributor Author

@simonjayhawkins Greenish.
IIUC, as long as the DLL version and the compiler toolchain version match, we should be fine.

@simonjayhawkins
Copy link
Collaborator

@lithomas1 i've restarted the failing job to be sure. Also reopened #135 to check current build status.

if both green will merge this and then rereun #135.

Should we maybe add something to the other section of 1.3.1 just in case there are issues so that users can more easily troubleshoot?

I assume this is a low-risk change. if not should we wait till finished with 1.3.x before merging?

@simonjayhawkins
Copy link
Collaborator

if both green will merge this and then rereun #135.

both green.

@jreback
Copy link
Contributor

jreback commented Jul 26, 2021

i guess need to revert this for the 1.3.x patch release builds

lithomas1 added a commit to lithomas1/pandas-wheels that referenced this pull request Jul 31, 2021
simonjayhawkins pushed a commit that referenced this pull request Aug 9, 2021
lithomas1 added a commit to lithomas1/pandas-wheels that referenced this pull request Aug 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants