Improve hashing of function and pseudocode objects#4254
Open
d-torrance wants to merge 4 commits intoMacaulay2:developmentfrom
Open
Improve hashing of function and pseudocode objects#4254d-torrance wants to merge 4 commits intoMacaulay2:developmentfrom
d-torrance wants to merge 4 commits intoMacaulay2:developmentfrom
Conversation
Contributor
|
Are you saying Claude Code can program in "d", despite the lack of any meaningful documentation? |
Member
Author
|
Yup! It was basically just copying and modifying the hashing function for the Expr union, but it did a decent job! |
Contributor
|
Interesting. I for one would be happy to never have to write another line of "d". |
mahrud
reviewed
May 4, 2026
| is x:CCcell do hash(x.v) | ||
| is x:Sequence do ( | ||
| -- the numbers here are the same as in binary lookup() in objects.d!! | ||
| -- these constants must match the manual hash computations in hashtables.dd |
Member
There was a problem hiding this comment.
Would it be feasible to have a single source of truth for all magic numbers?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We add hash codes to all members of the
Codeunion in the interpreter, which we then use to compute proper hashes of function and pseudocode objects.Before
After
Closes: #667
AI Disclosure
This was almost entirely vibe-coded by Claude Code, but with serious hand-holding.