Opt-out option in dialog#10
Conversation
Adds a radio button to the first time popup asking the user if he wants to enable the statistics collection. I tested it on my install and it seems to work as intended.
ModStatistics.csproj
Outdated
There was a problem hiding this comment.
These HintPaths would make the solution unbuildable by anyone without the same folder structure to find the references in.
I'd recommend putting a Dependencies folder at the solution root and referencing the assemblies from there, that way a relative path would be used for the HintPath and people can just be told to place the appropriate assemblies there.
An even better solution would be to include JsonFx.dll in the source tree as its license (MIT) allows, probably with its own license next to it to make it clear Majiir's ARR license does not apply to it. UnityEngine.dll may also be included which is allowed here. Unfortunately KSP's own Assembly-CSharp.dll would not be redistributable and have to be likely placed in a .gitignore so no one commits it.
There was a problem hiding this comment.
Yeah, I'm dumb and cannot into github. I mean to commit only the main file and also commited the solution files.
Can I edit a pull request to remove those 2 files?
There was a problem hiding this comment.
git checkout ef16415525 ./ModStatistics.csproj
git rm ./ModStatistics.sln
git commit -m "Reverting changes to project and solution"
Would create a commit which effectively backs out those changes, which you can then push and this pull request will be automatically updated.
(ef16415 being the commit that's currently the head of master in Majiir's repo).
There was a problem hiding this comment.
I still prefer to have the deps in source control (or better yet NuGet), but alas. 😃
Reverted the cdproj and delete the sln
2 participants
Adds a new radio button to the first-time popup that also asks the user if he wants to enable the statistics collection. I also moved a couple of checks in the start method so that the popup is executed first.
If I understand how the unity GUI stuff works, it should start enabled (it does in my install).
You will also want to edit the text in the popup I guess.