Use Godots own ZipReader instead of unzip. #131
Closed
novadragonDOTspace wants to merge 3 commits intoMakovWait:mainfrom
novadragonDOTspace:main
Closed
Use Godots own ZipReader instead of unzip. #131novadragonDOTspace wants to merge 3 commits intoMakovWait:mainfrom novadragonDOTspace:main
novadragonDOTspace wants to merge 3 commits intoMakovWait:mainfrom
novadragonDOTspace:main
Conversation
Deozaan
reviewed
Sep 16, 2025
| Output.push("unzip executed with exit code: %s" % exit_code) | ||
| DirAccess.make_dir_absolute(zip_path) | ||
| var reader: ZIPReader = ZIPReader.new() | ||
| var err : Error = reader.open(zip_path) |
There was a problem hiding this comment.
Should something be done with err in case there is an error?
Author
There was a problem hiding this comment.
I would muse that the original code doesnt do anything with the exit_code too, and err is equivalent to the exit code here. so, in a sense, it replicates the original logic.
Owner
|
The solution seems not to work correctly. I was unable to install the editor using it also, please remove extra empty lines between functions (make sure there are only two) |
Author
|
Gonna redo the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should Resolve #130 by using godots included ZipReader instead of unzip.