Skip to content

Allow filtering secret type#72

Merged
jboursier-mwb merged 2 commits intomainfrom
60-export-secrets-by-type
Apr 20, 2023
Merged

Allow filtering secret type#72
jboursier-mwb merged 2 commits intomainfrom
60-export-secrets-by-type

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Mar 24, 2023

This PR closes #60

@ghost ghost linked an issue Mar 24, 2023 that may be closed by this pull request
Security & Stuff added 2 commits March 24, 2023 12:40
Signed-off-by: Security & Stuff <74931194+SecurityAndStuff@users.noreply.github.com>
Signed-off-by: Security & Stuff <74931194+SecurityAndStuff@users.noreply.github.com>
@ghost ghost force-pushed the 60-export-secrets-by-type branch from 0ac2d49 to 9655385 Compare March 24, 2023 12:40
@ghost ghost added the enhancement New feature or request label Mar 24, 2023
if response.status_code == 403:
print("Secondary rate limit reached. Need to wait...")
# This can be secondary rate limit or SSO error
print(response.json()["message"])

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information

This expression logs [sensitive data (secret)](1) as clear text.
@ghost ghost requested a review from jboursier-mwb March 24, 2023 12:45
@jboursier-mwb jboursier-mwb added this pull request to the merge queue Apr 19, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 19, 2023
@jboursier-mwb jboursier-mwb merged commit 33657b0 into main Apr 20, 2023
@jboursier-mwb
Copy link
Copy Markdown
Collaborator

@SecurityAndStuff Can you eventually add an example with the filter on https://github.com/Malwarebytes/ghas-cli/wiki/Export-leaked-secrets-to-a-csv ?

@ghost ghost deleted the 60-export-secrets-by-type branch April 24, 2023 14:06
ghost pushed a commit that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Export secrets by type

2 participants