Combine function calls by "_" when parsing R folder#44
Open
jarodmeng wants to merge 1 commit intoMangoTheCat:masterfrom
Open
Combine function calls by "_" when parsing R folder#44jarodmeng wants to merge 1 commit intoMangoTheCat:masterfrom
jarodmeng wants to merge 1 commit intoMangoTheCat:masterfrom
Conversation
| rownames(res$`_`) <- NULL | ||
| } | ||
|
|
||
| return(res) |
Contributor
There was a problem hiding this comment.
Please omit the return.
Author
There was a problem hiding this comment.
I've modified the original commit to omit return().
Contributor
|
Thanks! Could you make the little change I commented on? |
Contributor
|
Thanks! Can you please also fix the test case that this breaks? See https://travis-ci.org/MangoTheCat/functionMap/jobs/148976920 |
omit return() fixed bug
Current coverage is 76.70% (diff: 100%)@@ master #44 diff @@
==========================================
Files 22 22
Lines 894 897 +3
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 685 688 +3
Misses 209 209
Partials 0 0
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.