Minor patches to add double-click dismiss of zoom/pan and protect against fragment use leaving minScale = 0 #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor cleanup of double-test in the scale code, add double-tap to dismiss zoom/translates, protect against fragments not hitting save/restore of the bundle (which they don't always) resulting in minScale = 0 which is a bad deal (just default to minScale=0 if we detect that; we've also lost maxscale too, but that's less of a problem.)
Oops -- wrong place.
Clean up double-test in the scale code, add double-click to dismiss scaling and protect from minScale = 0, which can happen if used in a fragment.
|
Any news? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.