feat: update partSchema to remove UUID validation and add report types#136
Merged
feat: update partSchema to remove UUID validation and add report types#136
Conversation
Collaborator
almog8k
commented
Nov 5, 2025
almog8k
commented
| Question | Answer |
|---|---|
| Bug fix | ✔ |
| New feature | ✔ |
CL-SHLOMIKONCHA
approved these changes
Nov 5, 2025
vitaligi
requested changes
Nov 5, 2025
| id: string; | ||
| errors: string[]; | ||
| } | ||
| export interface PolygonPartsValidationResponseBody { |
Contributor
There was a problem hiding this comment.
ResponseBody seems not to belong here
Collaborator
Author
There was a problem hiding this comment.
The response is the base of the report
Contributor
There was a problem hiding this comment.
please rename the interface to not include the term ResponseBody
Collaborator
Author
There was a problem hiding this comment.
PolygonPartsChunkValidationResult
…unkValidationResult
vitaligi
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.