Skip to content

fix: add unknown error and count it #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
almog8k merged 2 commits into from
Nov 26, 2025
+4 −2
Merged

fix: add unknown error and count it #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a55371
fix: add unknown error and count it
almog8k Nov 26, 2025
f5c8d4b
fix: add unknown error to PolygonPartValidationErrorsType
almog8k Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/constants/ingestion/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ export const ValidationErrorType = {
SMALL_GEOMETRY: 'Small_Geometry',
SMALL_HOLES: 'Small_Holes',
RESOLUTION: 'Resolution',
UNKNOWN: 'Unknown',
} as const;
/* eslint-enable @typescript-eslint/naming-convention */

Expand Down
1 change: 1 addition & 0 deletions src/schemas/ingestion/validationTask.schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ export const featuresErrorCountSchema = z.object({
resolution: counterSchema.describe('Number of features not matching the required resolution'),
smallHoles: counterSchema.describe('Number of features containing small holes'),
smallGeometries: counterSchema.describe('Number of features containing small geometries'),
unknown: counterSchema.describe('Number of features with unknown errors'),
});

export const thresholdsSchema = z.object({
Expand Down
4 changes: 2 additions & 2 deletions src/types/ingestion/report.type.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ import { ValidationErrorType } from '../../constants';

export type PolygonPartValidationErrorsType = Pick<
typeof ValidationErrorType,
'RESOLUTION' | 'GEOMETRY_VALIDITY' | 'SMALL_GEOMETRY' | 'SMALL_HOLES'
>[keyof Pick<typeof ValidationErrorType, 'GEOMETRY_VALIDITY' | 'RESOLUTION' | 'SMALL_GEOMETRY' | 'SMALL_HOLES'>];
'RESOLUTION' | 'GEOMETRY_VALIDITY' | 'SMALL_GEOMETRY' | 'SMALL_HOLES' | 'UNKNOWN'
>[keyof Pick<typeof ValidationErrorType, 'GEOMETRY_VALIDITY' | 'RESOLUTION' | 'SMALL_GEOMETRY' | 'SMALL_HOLES' | 'UNKNOWN'>];

export interface PolygonPartValidationError {
id: string;
Expand Down