Skip to content

Adding segment/vertex snapping options to the shape editor#39

Closed
mathijs-dumon wants to merge 17 commits intoMapWindow:developfrom
mathijs-dumon:develop
Closed

Adding segment/vertex snapping options to the shape editor#39
mathijs-dumon wants to merge 17 commits intoMapWindow:developfrom
mathijs-dumon:develop

Conversation

@mathijs-dumon
Copy link
Contributor

Should be merge only if the corresponding PR from MapWinGIS has been accepted (MapWindow/MapWinGIS#132)

@mathijs-dumon
Copy link
Contributor Author

@pmeems Is there anything I still need to do for this?

@pmeems
Copy link
Contributor

pmeems commented May 9, 2019

@mathijs-dumon Did you verify it is still working as expected with the latest dev code of MapWinGIS.
If so I will merge your changes.

@pmeems
Copy link
Contributor

pmeems commented May 9, 2019

@mathijs-dumon I did a review of your pull request and it has many more changes and improvements than just 'Adding segment/vertex snapping options to the shape editor'.
That is fine but to track changes I want to ask you if you can make a list of your changes so I can add it to our issue tracker and then it will end up in the release notes.

@mathijs-dumon
Copy link
Contributor Author

Ah shoot, I actually wanted to make seperate pull requests for these. Didn't realize this pr was on the develop branch. My bad.
I'll do as you suggest and document the changes with the relevant commits asap.

…29 MW5CORE-230 Adding events, making events cancellable, allowing plugins to have more than one registered event delegate, changing to Csharp 7.1
…erves style and labels, and small fixes to persist layer styles

after reloads and persisting/loading layer styles to/from spatial databases
@mathijs-dumon
Copy link
Contributor Author

closing as this is no longer relevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants