Skip to content

[IMPAC-741] Lmi widgets improvement#1

Merged
MarcoBgn merged 4 commits intoMarcoBgn:feature/lmi-boltfrom
iseessel:improvement/741-impac-lmi-widgets-improvement
Mar 1, 2018
Merged

[IMPAC-741] Lmi widgets improvement#1
MarcoBgn merged 4 commits intoMarcoBgn:feature/lmi-boltfrom
iseessel:improvement/741-impac-lmi-widgets-improvement

Conversation

@iseessel
Copy link
Copy Markdown

@iseessel iseessel force-pushed the improvement/741-impac-lmi-widgets-improvement branch from d2c813a to c3014b2 Compare February 27, 2018 01:14
@MarcoBgn
Copy link
Copy Markdown
Owner

MarcoBgn commented Feb 27, 2018

I will also ask for a new branch on Maestrano's, so PR's can be reviewed and managed there.

@xaun
Copy link
Copy Markdown

xaun commented Feb 27, 2018

Approving the changes as Marco asked for a review, as you would know @iseessel, if this is going to be merged into maestrano releases, it will need to be changed for your refactor on the HighchartsFactory. If not then the addition are ok for me.

@iseessel
Copy link
Copy Markdown
Author

@MarcoBgn The left axis represents average visits per customer which is: "The total transaction count at the store divided by the number of customers in the same time period."

As far as I'm concerned, this is not a $ , but are number of transactions per person.

@MarcoBgn
Copy link
Copy Markdown
Owner

MarcoBgn commented Feb 27, 2018

@iseessel yes, definitely. My bad, I rushed through and thought about the average spend. I have deleted the comment. Just waiting for the branch to be created 👍

@iseessel
Copy link
Copy Markdown
Author

@MarcoBgn Sounds great!

@xaun And believe me that has occurred to me ;).

@MarcoBgn MarcoBgn merged commit 6aa4439 into MarcoBgn:feature/lmi-bolt Mar 1, 2018
MarcoBgn pushed a commit that referenced this pull request May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants