Skip to content

Conversation

@s-moon
Copy link
Contributor

@s-moon s-moon commented Nov 25, 2015

Small punctuation changes.

Small punctuation changes.
@s-moon
Copy link
Contributor Author

s-moon commented Nov 25, 2015

I'm wondering if I should have made some of those full-stops, colons, as you did in the first example? This applies to the other pull-request, too.

Not sure :-( Both seem valid, but I didn't notice that you had already started with the colon in the first one.

Are you able to selectively merge? Leave out the full stops for the parts where it refers to examples, but keep any other changes? I can go back and use colons consistently later.

Also added bracket to first part of text referencing file-format.
@s-moon
Copy link
Contributor Author

s-moon commented Nov 25, 2015

I found a way to fix my broken fixes! Now uses colons so should be fine to merge in once you check it over. Sorry for the multi-commits!

@MarcosMeli
Copy link
Owner

Hi s-moon I'm merging when I get some time, just cheking a bit before merge but nothing wrong with the edits, Thanks !!

You can also create a unifified Pull Request for changes in various files if you want, if not, is fine too

Thanks for your contributions !!

MarcosMeli added a commit that referenced this pull request Nov 26, 2015
Minor formatting changes.
@MarcosMeli MarcosMeli merged commit 832eb10 into MarcosMeli:master Nov 26, 2015
@s-moon
Copy link
Contributor Author

s-moon commented Nov 26, 2015

That would be easier for you (one pull) but that facility on your website to edit pages is brilliant (and simple for me) though seems to do only one page at a time. Is that right? Can I edit multiple and just do one pull request?

@MarcosMeli
Copy link
Owner

You are right, you can only edit one file that way, and is the best one, so is all fine with multiple PRs 👍

Thanks for your help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants