Skip to content

Remove MustNotifyRead in MultiRecordEngine #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcavigelli merged 1 commit into from
May 23, 2021
Merged

Remove MustNotifyRead in MultiRecordEngine #256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions FileHelpers/Engines/MultiRecordEngine.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ public object[] ReadStream(IRecordReader reader)
OnProgress(new ProgressEventArgs(currentRecord, -1));

BeforeReadEventArgs<object> e = null;
if (MustNotifyRead) // Avoid object creation
if (info.NotifyRead) // Avoid object creation
{
e = new BeforeReadEventArgs<object>(this, record, currentLine, LineNumber);
skip = OnBeforeReadRecord(e);
Expand All @@ -212,7 +212,7 @@ public object[] ReadStream(IRecordReader reader)
if (skip == false) {
var values = new object[info.FieldCount];
if (info.Operations.StringToRecord(record, line, values)) {
if (MustNotifyRead) // Avoid object creation
if (info.NotifyRead) // Avoid object creation
skip = OnAfterReadRecord(currentLine, record, e.RecordLineChanged, LineNumber);

if (skip == false)
Expand Down Expand Up @@ -646,7 +646,7 @@ private void ReadNextRecord()
var values = new object[info.FieldCount];
mLastRecord = info.Operations.StringToRecord(line, values);

if (MustNotifyRead)
if (info.NotifyRead)
{
OnAfterReadRecord(currentLine, mLastRecord, false, LineNumber);
}
Expand Down