Customizable CultureInfo at field and record level.

[jcchalte]

Currently, most Field converters expose a way to set the decimal separator. The user can choose either the dot "." or the comma ",", and the group separator is set to the other one. Therefore, it is not possible to use the French culture, as in this culture, the "dot" is not allowed as a group separator. Even if the developer sets the separator to the comma, it does not prevent from using an english compliant file.

In the ConverterHelpers.cs file, more precisely in the createCulture method, if the decimal separator is set to a comma, the group separator is hardcoded as the dot, which result in an invalid culture behaviour.

We wanted to find a way to specify that our files use French culture without breaking existing code, so made two changes to the code :

• we added the option to use the first argument of FieldConvert to specify either the decimal separator or a specific culture name (eg. "en-US", "fr-FR" etc.). The existing usage will remain the same, but user can now use a construct like this :

[DelimitedRecord("|")]
        public class RecordWithFieldCulture
        {
            [FieldConverter(ConverterKind.Decimal, "fr-FR")]
            public decimal DecimalFieldWithFrenchCulture;

            public decimal DecimalFieldWithoutCulture;
        }

• we also added a new optional parameter to both DelimitedRecordAttributes and FixedLengthRecordAttribute to specify a culture that will be used on each converter. If it is not specified, the behaviour remains exactly the same as before (it uses the current culture with a dot as a separator). It should not change anything for existing code. The user can even specify another culture on specific fields if he wants to mix cultures.

        [DelimitedRecord("|", "fr-FR")]
        public class RecordWithDefaultCulture
        {
            public decimal DecimalFieldWithoutCulture;


            [FieldConverter(ConverterKind.Decimal, "en-US")]
            public decimal DecimalFieldWithEnglishCulture;
        }

We added unit tests and usage demo in the FileHelpers.Tests.Converters.DefaultCultureInfo class.

[mcavigelli]

Salut Jean-Christophe

Thank you for your well documented and explained pull request.
I'm reviewing it this weekend.

Thank you for your patience, Matthias

[mcavigelli]

Salut Jean-Christophe

Thank you for your useful pull request.

The unit tests were really useful to understand the feature you have implemented.
There are only two small changes I (on behalf of ReSharper:-)) would like you to do, see the inline
comments.

However for your next pull request may I ask you to split your commits into

• file formatting commits
• refactoring commits (renaming of variables and methods, extracting of methods)
• changes of functionality

Smaller change sets per commit will help reviewers to understand the code quicker.

Thank you again for your contribution to FileHelpers and thank you for your patience,
Matthias

[mcavigelli]

Auto propety can be get only.

[mcavigelli]

"this" qualifier is not necessary