SSP - 8517 / Update Prebid with pubmatic s2s#24
Open
adriafolchmrf wants to merge 1 commit intomarfeelfrom
Open
SSP - 8517 / Update Prebid with pubmatic s2s#24adriafolchmrf wants to merge 1 commit intomarfeelfrom
adriafolchmrf wants to merge 1 commit intomarfeelfrom
Conversation
alexarvanitidismrf
approved these changes
Sep 27, 2018
| @@ -0,0 +1,328 @@ | |||
| import * as utils from 'src/utils'; | |||
There was a problem hiding this comment.
@alexarvanitidismrf @adriafolchmrf so this is a copy of the original pubmaticBidAdapter ?
Author
There was a problem hiding this comment.
Kind of, we changed only the BIDDER_CODE to pubmatic_client. This is how we are doing s2s and client side in rubicon as well so we replicated it
There was a problem hiding this comment.
I see!
We need to put a reminder here somewhere, because when I updated the prebid version, I didn't think of changing the rabicon file, I didn't realise it existed... So all good for this PR, and in my update PR I'll add something about it!
florevallatmrf
approved these changes
Sep 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the pubmatic client as an extra adapter, to enable support of pubmatic server-to-server. We're going to roll this out for everyone once this is merged