fix(bidcaching): filter sizes sent through bidcaching using the current auction ones#48
Merged
pedrolopezmrf merged 2 commits intomarfeel-masterfrom Feb 26, 2020
Merged
Conversation
pedrolopezmrf
changed the title
src/targeting.js
Outdated
| const bidsToFilter = bidsByReferrer[lastLocation] || filterBidsByAdUnit(bidsReceived); | ||
| const currentAuctionSizes = getLastAuctionSizes(); | ||
|
|
||
| bidsToProcess = bidsToFilter.filter(filterBidsBySizes(currentAuctionSizes)); |
There was a problem hiding this comment.
Suggested change
| bidsToProcess = bidsToFilter.filter(filterBidsBySizes(currentAuctionSizes)); | |
| bidsToProcess = bidsToFilter.filter(bid => isBidSizeAllowed(bid, allowedSizes)); |
oscarmarimrf
suggested changes
Feb 26, 2020
src/marfeelTools.js
Outdated
Comment on lines
61
to
69
| export const filterBidsBySizes = (sizesToFilter) => { | ||
| const sizesToFilterUnified = sizesToFilter.map(sizes => sizes.join(SIZE_JOINER)); | ||
|
|
||
| return (bid) => { | ||
| const bidSize = [bid.width, bid.height].join(SIZE_JOINER); | ||
|
|
||
| return sizesToFilterUnified.includes(bidSize); | ||
| } | ||
| } |
There was a problem hiding this comment.
export const isBidSizeAllowed = (bid, allowedSizes) => {
const allowedSizesNormalized = allowedSizes.map(sizes => sizes.join(SIZE_JOINER));
const bidSize = [bid.width, bid.height].join(SIZE_JOINER);
return allowedSizesNormalized.includes(bidSize);
}
oscarmarimrf
approved these changes
Feb 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.