Merged
Conversation
oscarmarimrf
suggested changes
Mar 4, 2020
modules/consentManagement.js
Outdated
| gdprDataHandler.setConsentData(consentData); | ||
|
|
||
| if (!!consentData.vendorData) { | ||
| if (consentData.vendorData) { |
test/spec/marfeelTools_spec.js
Outdated
| */ | ||
|
|
||
| import { filterBidsBySizes } from './marfeelTools'; | ||
| import { isBidSizeAllowed, add1x1IfAllowed } from './marfeelTools'; |
There was a problem hiding this comment.
You're importing the private helper instead of getAllowedSizes. Did this test pass?
Suggested change
| import { isBidSizeAllowed, add1x1IfAllowed } from './marfeelTools'; | |
| import { isBidSizeAllowed, getAllowedSizes } from './marfeelTools'; |
| }]) | ||
| }); | ||
|
|
||
| it('adds 1x1 to allowed sizes if 300x250 is present', function() { |
There was a problem hiding this comment.
This is defined inside the isBidSizeAllowed() block.
Shouldn't we create a new block for getAllowedSizes?
Suggested change
| it('adds 1x1 to allowed sizes if 300x250 is present', function() { | |
| describe('getAllowedSizes', function() { | |
| it('adds 1x1 to allowed sizes if 300x250 is present', function() { |
Also, can we add a test to ensure the 1x1 is not added when there is no 300x250?
oscarmarimrf
approved these changes
Mar 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.