Fix issues with metastate serialization #4785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonBock
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4767
From @JasonBock
I'm getting an exception with the metastate implementation. Well, I'm getting a couple, but here's one I found: System.ArgumentException : Metastate cannot be empty. (Parameter 'metastate'). The issue is that when I serialize an object that has no metastate, like a CommandBase, calling GetMetastate() returns a 0-byte array. Then, during deserialization, I pass that 0-byte array to SetMetastate(). I think the implementation in IMobileObjectMetastate.SetMetastate(Byte[] metastate) should handle this case and not consider it to be an error.
I'm also seeing what looks like weird metastate issues with the flag properties. For example, I have a test that fetches a BO, which means all of these properties are false: IsNew, IsDeleted, IsDirty, and IsChild. I then serialize the object, and it seems like the metastate values in the byte array are all 0, or false. But, when I deserialize the object, IsNew and IsDirty are true.